third_party/WebKit/Source/core/testing/Internals.h - Issue 2087293003: [DevTools] Network.emulateNetworkConditions now affects NetworkStateNotifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/Internals.h

Issue 2087293003: [DevTools] Network.emulateNetworkConditions now affects NetworkStateNotifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: browser test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp ('K') | « third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp ('k') | third_party/WebKit/Source/core/testing/Internals.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/testing/Internals.h

diff --git a/third_party/WebKit/Source/core/testing/Internals.h b/third_party/WebKit/Source/core/testing/Internals.h

index 3c1d336ce2ae11798ccdf3d842ebf514d9fd5b61..dd066eb433effe355dd39647f2f42fda37eb9e51 100644

--- a/third_party/WebKit/Source/core/testing/Internals.h

+++ b/third_party/WebKit/Source/core/testing/Internals.h

@@ -343,10 +343,8 @@ public:

bool ignoreLayoutWithPendingStylesheets(Document*);

- // Test must call setNetworkStateNotifierTestOnly(true) before calling setNetworkConnectionInfo or

- // setNetworkStateMaxBandwidth.

- void setNetworkStateNotifierTestOnly(bool);

- void setNetworkConnectionInfo(const String&, double downlinkMaxMbps, ExceptionState&);

+ void setNetworkConnectionInfoOverride(bool, const String&, double downlinkMaxMbps, ExceptionState&);

+ void clearNetworkConnectionInfoOverride();

unsigned countHitRegions(CanvasRenderingContext*);