third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-reload.html - Issue 2087293003: [DevTools] Network.emulateNetworkConditions now affects NetworkStateNotifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-reload.html

Issue 2087293003: [DevTools] Network.emulateNetworkConditions now affects NetworkStateNotifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: browser test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-conn-type.html ('k') | third_party/WebKit/LayoutTests/http/tests/webfont/font-display-intervention.html » ('j') | third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-reload.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-reload.html b/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-reload.html

index f4d03d2f633c1f5e32305518b4c9c5fe57127e26..00149698f4ad64d575bbd7cfd3995602435b2bcf 100644

--- a/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-reload.html

+++ b/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-reload.html

@@ -11,13 +11,12 @@

}, "window.internals is required for the test to run");

internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrameOnSlowConnections(true);

- internals.setNetworkStateNotifierTestOnly(true);

- internals.setNetworkConnectionInfo('cellular2g', 1.0);

+ internals.setNetworkConnectionInfoOverride(true, 'cellular2g', 1.0);

internals.evictAllResources();

window.addEventListener('beforeunload', function() {

internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrameOnSlowConnections(false);

- internals.setNetworkStateNotifierTestOnly(false);

+ internals.clearNetworkConnectionInfoOverride();

// Remove localStorage items, just in case they haven't been

// already removed, due to test failure.

if (window.localStorage.getItem("errorCount") !== null) {