content/browser/devtools/protocol/network_handler.cc - Issue 2087293003: [DevTools] Network.emulateNetworkConditions now affects NetworkStateNotifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/network_handler.cc

Issue 2087293003: [DevTools] Network.emulateNetworkConditions now affects NetworkStateNotifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dcheck Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/network_handler.h ('k') | third_party/WebKit/LayoutTests/http/tests/loading/doc-write-async-third-party-script.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/network_handler.cc

diff --git a/content/browser/devtools/protocol/network_handler.cc b/content/browser/devtools/protocol/network_handler.cc

index 7ecc06fe739d1c2c4445f9d83b202e0ba60f6d8d..ae9a58d7ce8a196e7ddc29895796a50a2c0ed3da 100644

--- a/content/browser/devtools/protocol/network_handler.cc

+++ b/content/browser/devtools/protocol/network_handler.cc

@@ -289,11 +289,13 @@ Response NetworkHandler::CanEmulateNetworkConditions(bool* result) {

return Response::OK();

}

-Response NetworkHandler::EmulateNetworkConditions(bool offline,

- double latency,

- double download_throughput,

- double upload_throughput) {

- return Response::InternalError("EmulateNetworkConditions is not supported");

+Response NetworkHandler::EmulateNetworkConditions(

+ bool offline,

+ double latency,

+ double download_throughput,

+ double upload_throughput,

+ const std::string* connection_type) {

+ return Response::FallThrough();

}

Response NetworkHandler::GetCertificateDetails(