Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: chrome/browser/devtools/devtools_network_protocol_handler.cc

Issue 2087293003: [DevTools] Network.emulateNetworkConditions now affects NetworkStateNotifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dcheck Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_sanity_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_network_protocol_handler.cc
diff --git a/chrome/browser/devtools/devtools_network_protocol_handler.cc b/chrome/browser/devtools/devtools_network_protocol_handler.cc
index 8bd44d9bb4e11e1881c9caf756c090a96ea1fc5e..2c39ad7ace6f3fc683d916d49f96688ab821a8db 100644
--- a/chrome/browser/devtools/devtools_network_protocol_handler.cc
+++ b/chrome/browser/devtools/devtools_network_protocol_handler.cc
@@ -92,9 +92,7 @@ DevToolsNetworkProtocolHandler::EmulateNetworkConditions(
upload_throughput));
UpdateNetworkState(agent_host, std::move(conditions));
-
- std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue());
- return DevToolsProtocol::CreateSuccessResponse(command_id, std::move(result));
+ return nullptr; // Fall-through.
}
void DevToolsNetworkProtocolHandler::UpdateNetworkState(
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_sanity_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698