third_party/WebKit/Source/core/testing/Internals.idl - Issue 2087293003: [DevTools] Network.emulateNetworkConditions now affects NetworkStateNotifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/Internals.idl

Issue 2087293003: [DevTools] Network.emulateNetworkConditions now affects NetworkStateNotifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp ('K') | « third_party/WebKit/Source/core/testing/Internals.cpp ('k') | third_party/WebKit/Source/devtools/front_end/Tests.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/testing/Internals.idl

diff --git a/third_party/WebKit/Source/core/testing/Internals.idl b/third_party/WebKit/Source/core/testing/Internals.idl

index 023bd48df95b6492e840e78db603ec560ebcc298..8bd6ebf01ce2881d065e99a63aec34dfaebafd7d 100644

--- a/third_party/WebKit/Source/core/testing/Internals.idl

+++ b/third_party/WebKit/Source/core/testing/Internals.idl

@@ -298,10 +298,9 @@

boolean ignoreLayoutWithPendingStylesheets(Document document);

- // These functions are for testing NetInfo. You must call setNetworkStateNotifierTestOnly(true)

- // before calling setNetworkConnectionInfo.

- void setNetworkStateNotifierTestOnly(boolean testOnly);

- [RaisesException] void setNetworkConnectionInfo(DOMString type, double downlinkMaxMbps);

+ // These functions are for testing NetInfo. You must call clearNetworkConnectionInfoOverride() at the end.

+ [RaisesException] void setNetworkConnectionInfoOverride(boolean onLine, DOMString type, double downlinkMaxMbps);

+ void clearNetworkConnectionInfoOverride();

// This function is for testing HitRegions on Canvas2D.

unsigned long countHitRegions(CanvasRenderingContext2D context);