Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 2087293002: Remove calls to deprecated MessageLoop methods in gin. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in gin. This CL makes the following replacements in gin: Before After ---------------------------------------------------------- x.PostTask() x.task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x->PostTask() y->task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x.Run() RunLoop().Run() x.RunUntilIdle() RunLoop().RunUntilIdle() x->Run() RunLoop().Run() x->RunUntilIdle() RunLoop().RunUntilIdle() If |y| isn't MessageLoopForUI::current() or MessageLoopForIO::current() y.message_loop()->task_runner() y.task_runner() y->message_loop()->task_runner() y->task_runner() ---------------------------------------------------------- |x| is a base::MessageLoop(ForUI|ForIO) or a pointer to a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread or a pointer to a base::Thread. This CL was generated using the MessageLoopDeprecatedMethods clang-tidy fix available on the associated bug. Only files that compile on Mac are affected. Follow-up CLs will make these replacements for other platforms. This CL doesn't change code behavior. BUG=616447 R=jochen@chromium.org Committed: https://crrev.com/156962f3287f15059fef4ee6b8f7eb2accd05c9a Cr-Commit-Position: refs/heads/master@{#402108}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M gin/modules/timer_unittest.cc View 6 chunks +9 lines, -7 lines 0 comments Download
M gin/shell/gin_main.cc View 2 chunks +2 lines, -1 line 0 comments Download
M gin/test/file_runner.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-22 17:37:30 UTC) #1
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-24 13:36:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2087293002/1
4 years, 5 months ago (2016-06-27 03:39:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 04:15:30 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 04:17:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/156962f3287f15059fef4ee6b8f7eb2accd05c9a
Cr-Commit-Position: refs/heads/master@{#402108}

Powered by Google App Engine
This is Rietveld 408576698