Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1207)

Unified Diff: content/browser/gpu/gpu_data_manager_impl_private.cc

Issue 2087283003: Fixed running gpu process with kOverrideUseGLWithOSMesaForTests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/gpu/gpu_data_manager_impl_private.cc
diff --git a/content/browser/gpu/gpu_data_manager_impl_private.cc b/content/browser/gpu/gpu_data_manager_impl_private.cc
index bff0dcbb7945b35f97a0752080a5f8123fa6c447..802aa99c2db87f3db8091a486967edf0b1531458 100644
--- a/content/browser/gpu/gpu_data_manager_impl_private.cc
+++ b/content/browser/gpu/gpu_data_manager_impl_private.cc
@@ -527,8 +527,12 @@ void GpuDataManagerImplPrivate::Initialize() {
}
gpu::GPUInfo gpu_info;
- if (command_line->GetSwitchValueASCII(switches::kUseGL) ==
- gl::kGLImplementationOSMesaName) {
+ const bool force_osmesa =
+ (command_line->GetSwitchValueASCII(switches::kUseGL) ==
+ gl::kGLImplementationOSMesaName) ||
+ (!command_line->HasSwitch(switches::kUseGL) &&
danakj 2016/06/23 20:01:13 Ideally we never have both kUseGL and kOverrideUse
+ command_line->HasSwitch(switches::kOverrideUseGLWithOSMesaForTests));
+ if (force_osmesa) {
// If using the OSMesa GL implementation, use fake vendor and device ids to
// make sure it never gets blacklisted. This is better than simply
// cancelling GPUInfo gathering as it allows us to proceed with loading the
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698