Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2087233006: [ios] Moved web_test_suite.h to ios/web/public. (Closed)

Created:
4 years, 6 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 6 months ago
Reviewers:
Jackie Quinn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Moved web_test_suite.h to ios/web/public. This header is used by chrome_test_suite. BUG=616244 Committed: https://crrev.com/26b402b376aabbb5873a9c129adf74b60d033fda Cr-Commit-Position: refs/heads/master@{#401833}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -29 lines) Patch
M ios/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/ios_web.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + ios/web/public/test/web_test_suite.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/web/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/test/web_test_suite.h View 1 chunk +1 line, -24 lines 1 comment Download
M ios/web/test/web_test_suite.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087233006/1
4 years, 6 months ago (2016-06-24 03:46:13 UTC) #2
Eugene But (OOO till 7-30)
Could you please CQ if this looks good to you. https://codereview.chromium.org/2087233006/diff/1/ios/web/test/web_test_suite.h File ios/web/test/web_test_suite.h (right): https://codereview.chromium.org/2087233006/diff/1/ios/web/test/web_test_suite.h#newcode8 ...
4 years, 6 months ago (2016-06-24 03:47:16 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-24 05:09:57 UTC) #6
Jackie Quinn
lgtm
4 years, 6 months ago (2016-06-24 07:49:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087233006/1
4 years, 6 months ago (2016-06-24 07:50:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 07:57:53 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/26b402b376aabbb5873a9c129adf74b60d033fda Cr-Commit-Position: refs/heads/master@{#401833}
4 years, 6 months ago (2016-06-24 08:00:09 UTC) #12
Eugene But (OOO till 7-30)
4 years, 6 months ago (2016-06-24 15:05:53 UTC) #13
Message was sent while issue was closed. 
Thanks!

Powered by Google App Engine
This is Rietveld 408576698