Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1188)

Issue 2087233005: [arm64] Fix handling of CMN and ADD/SUB with overflow in VisitBinop. (Closed)

Created:
4 years, 6 months ago by georgia.kouveli
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64] Fix handling of CMN and ADD/SUB with overflow in VisitBinop. CMN is a flag-setting add operation, and therefore is commutative. {Add,Sub}WithOverflow generate ADD/SUB instructions that cannot support a ROR shift. BUG= Committed: https://crrev.com/f5d90fc9f2e2aa324f3a00d9ac3f6445f5f2d126 Cr-Commit-Position: refs/heads/master@{#37212}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -24 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 5 chunks +78 lines, -18 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 5 chunks +188 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
georgia.kouveli
4 years, 6 months ago (2016-06-23 10:26:19 UTC) #2
epertoso
lgtm
4 years, 6 months ago (2016-06-23 10:48:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087233005/1
4 years, 6 months ago (2016-06-23 10:53:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 11:27:24 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 11:29:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5d90fc9f2e2aa324f3a00d9ac3f6445f5f2d126
Cr-Commit-Position: refs/heads/master@{#37212}

Powered by Google App Engine
This is Rietveld 408576698