Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: src/flags.cc

Issue 2087223002: Make syntax for boolean flags more discoverable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/flags.cc
diff --git a/src/flags.cc b/src/flags.cc
index f67defd5a98948d55b62b8fbe4840d3c1c3a73fc..f7ae004ac26e2bf7e80583b0c4e87b19fdddb5ca 100644
--- a/src/flags.cc
+++ b/src/flags.cc
@@ -429,6 +429,10 @@ int FlagList::SetFlagsFromCommandLine(int* argc,
PrintF(stderr, "Error: illegal value for flag %s of type %s\n"
"Try --help for options\n",
arg, Type2String(flag->type()));
+ if (is_bool_type) {
+ PrintF(stderr,
+ "To set or unset a boolean flag, use --flag or --no-flag.\n");
+ }
return_code = j;
break;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698