Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 2087223002: Make syntax for boolean flags more discoverable. (Closed)

Created:
4 years, 6 months ago by bgeron
Modified:
4 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make syntax for boolean flags more discoverable. Because --help does not show how to use boolean flags. R=jkummerow@chromium.org BUG= Committed: https://crrev.com/21fdde3c76a32eb5de74b194e532b2b4d4719170 Cr-Commit-Position: refs/heads/master@{#37193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bgeron
Please take a look. Thanks, Bram (the intern)
4 years, 6 months ago (2016-06-22 13:01:00 UTC) #1
Jakob Kummerow
lgtm
4 years, 6 months ago (2016-06-22 14:52:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087223002/1
4 years, 6 months ago (2016-06-22 15:20:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 16:05:57 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 16:07:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21fdde3c76a32eb5de74b194e532b2b4d4719170
Cr-Commit-Position: refs/heads/master@{#37193}

Powered by Google App Engine
This is Rietveld 408576698