Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2087173003: Use native CSS variables in Polymer (Closed)

Created:
4 years, 6 months ago by michaelpg
Modified:
4 years, 6 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use native CSS variables in Polymer Provides nominal load time savings. BUG=597347 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8aa79b075e1943601117dce455375b7c93c4a924 Cr-Commit-Position: refs/heads/master@{#401373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M ui/webui/resources/js/polymer_config.js View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
michaelpg
4 years, 6 months ago (2016-06-22 18:20:54 UTC) #4
Dan Beam
oh yeahhhhh! lgtm
4 years, 6 months ago (2016-06-22 18:22:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087173003/1
4 years, 6 months ago (2016-06-22 18:28:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 18:51:39 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 18:58:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8aa79b075e1943601117dce455375b7c93c4a924
Cr-Commit-Position: refs/heads/master@{#401373}

Powered by Google App Engine
This is Rietveld 408576698