[turbofan] Add dedicated test for check constant folding.

[turbofan] Add dedicated test for check constant folding.

This adds a dedicated test to make sure we don't try constant folding on
checks (in this case CheckTaggedPointer), which would generate invalid
code as we removing checks that guard the constant without knowing
whether it's safe to do so.

R=jarin@chromium.org

Committed: https://crrev.com/a334354288e854053012daea1cca7eb5a7c01a21
Cr-Commit-Position: refs/heads/master@{#37168}

[Benedikt Meurer, 2016-06-22 06:31:32]

Hey Jaro,

Here's the comment plus the test.
Please take a look.

Thanks,
Benedikt

[Jarin, 2016-06-22 06:34:58]

lgtm

[Benedikt Meurer, 2016-06-22 06:35:07]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-06-22 06:35:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2087153002/1

[commit-bot: I haz the power, 2016-06-22 06:49:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 06:49:34]

Try jobs failed on following builders:
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/3598)
  v8_mac_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[Benedikt Meurer, 2016-06-22 07:52:54]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-06-22 07:52:54]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2087153002/#ps20001
(title: "Fix test")

[commit-bot: I haz the power, 2016-06-22 07:52:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2087153002/20001

[commit-bot: I haz the power, 2016-06-22 08:19:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-22 08:21:00]

Description was changed from

==========
[turbofan] Add dedicated test for check constant folding.

This adds a dedicated test to make sure we don't try constant folding on
checks (in this case CheckTaggedPointer), which would generate invalid
code as we removing checks that guard the constant without knowing
whether it's safe to do so.

R=jarin@chromium.org
==========

to

==========
[turbofan] Add dedicated test for check constant folding.

This adds a dedicated test to make sure we don't try constant folding on
checks (in this case CheckTaggedPointer), which would generate invalid
code as we removing checks that guard the constant without knowing
whether it's safe to do so.

R=jarin@chromium.org

Committed: https://crrev.com/a334354288e854053012daea1cca7eb5a7c01a21
Cr-Commit-Position: refs/heads/master@{#37168}
==========

[commit-bot: I haz the power, 2016-06-22 08:21:01]

Patchset 2 (id:??) landed as
https://crrev.com/a334354288e854053012daea1cca7eb5a7c01a21
Cr-Commit-Position: refs/heads/master@{#37168}