Move SSLConfig class from ssl_config_service.h to ssl_config.h

Move SSLConfig class from ssl_config_service.h to ssl_config.h

SSLConfigService depends on CRLSet that is not useful in net_nacl.
Separate SSLConfig from SSLConfigService, so that they can be compiled
independently.

Also replaced default_version_(min|max) in SSLConfigService with 
constants kDefaultSSLVersion(Min|Max).

BUG=276739
TBR=wtc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258843

[Sergey Ulanov, 2014-03-21 19:14:53]

This is needed for https://codereview.chromium.org/188873004/

[Ryan Sleevi, 2014-03-21 19:24:05]

https://codereview.chromium.org/208713004/diff/20001/net/ssl/ssl_config.h
File net/ssl/ssl_config.h (right):

https://codereview.chromium.org/208713004/diff/20001/net/ssl/ssl_config.h#new...
net/ssl/ssl_config.h:30: static uint16 kDefaultSSLVersionMax =
I would rather keep the actual definitions for these in the .cc file, in the
same way we do command-line flags and the like.

That also avoids header propagation issues (eg: IWYU says we should be including
an OpenSSL public header here to ensure SSL_OP_NO_TLS* is defined, but we don't;
we're relying on x509_certificate.h, which is bad)

[Sergey Ulanov, 2014-03-21 19:56:53]

https://codereview.chromium.org/208713004/diff/20001/net/ssl/ssl_config.h
File net/ssl/ssl_config.h (right):

https://codereview.chromium.org/208713004/diff/20001/net/ssl/ssl_config.h#new...
net/ssl/ssl_config.h:30: static uint16 kDefaultSSLVersionMax =
On 2014/03/21 19:24:05, Ryan Sleevi wrote:
> I would rather keep the actual definitions for these in the .cc file, in the
> same way we do command-line flags and the like.
> 
> That also avoids header propagation issues (eg: IWYU says we should be
including
> an OpenSSL public header here to ensure SSL_OP_NO_TLS* is defined, but we
don't;
> we're relying on x509_certificate.h, which is bad)

Done.

[Ryan Sleevi, 2014-03-21 20:03:02]

LGTM, mod IWYU issue

https://codereview.chromium.org/208713004/diff/40001/net/ssl/ssl_config.cc
File net/ssl/ssl_config.cc (right):

https://codereview.chromium.org/208713004/diff/40001/net/ssl/ssl_config.cc#ne...
net/ssl/ssl_config.cc:6: 
IWYU?

#if defined(USE_OPENSSL)
#include <openssl/ssl.h>
#endif

[Sergey Ulanov, 2014-03-21 20:06:21]

https://codereview.chromium.org/208713004/diff/40001/net/ssl/ssl_config.cc
File net/ssl/ssl_config.cc (right):

https://codereview.chromium.org/208713004/diff/40001/net/ssl/ssl_config.cc#ne...
net/ssl/ssl_config.cc:6: 
On 2014/03/21 20:03:02, Ryan Sleevi wrote:
> IWYU?
> 
> #if defined(USE_OPENSSL)
> #include <openssl/ssl.h>
> #endif

Done.

[Sergey Ulanov, 2014-03-21 20:06:31]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2014-03-21 20:07:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/208713004/60001

[commit-bot: I haz the power, 2014-03-21 20:08:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-21 20:08:46]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[Sergey Ulanov, 2014-03-21 21:20:55]

+wtc@ in TBR for chrome/browser/net

[Sergey Ulanov, 2014-03-21 21:21:00]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2014-03-21 21:21:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/208713004/60001

[wtc, 2014-03-22 01:29:41]

Patch set 3 LGTM. Please note the comment marked with "IMPORTANT".

https://codereview.chromium.org/208713004/diff/60001/chrome/browser/net/ssl_c...
File chrome/browser/net/ssl_config_service_manager_pref.cc (left):

https://codereview.chromium.org/208713004/diff/60001/chrome/browser/net/ssl_c...
chrome/browser/net/ssl_config_service_manager_pref.cc:286: config->version_max =
net::SSLConfigService::default_version_max();

IMPORTANT: Are you sure these two lines can be deleted?

https://codereview.chromium.org/208713004/diff/60001/net/ssl/ssl_config_servi...
File net/ssl/ssl_config_service.cc (right):

https://codereview.chromium.org/208713004/diff/60001/net/ssl/ssl_config_servi...
net/ssl/ssl_config_service.cc:10: #include "net/cert/crl_set.h"

Nit: "base/memory/ref_counted.h" and "net/cert/crl_set.h" are already included
in ssl_config_service.h.

https://codereview.chromium.org/208713004/diff/60001/net/ssl/ssl_config_servi...
net/ssl/ssl_config_service.cc:14: #include <openssl/ssl.h>

We should be able to remove this header.

https://codereview.chromium.org/208713004/diff/60001/net/ssl/ssl_config_servi...
File net/ssl/ssl_config_service.h (right):

https://codereview.chromium.org/208713004/diff/60001/net/ssl/ssl_config_servi...
net/ssl/ssl_config_service.h:15: #include "net/cert/cert_status_flags.h"

We should be able to remove "base/basictypes.h",  "base/strings/string_piece.h",
and "net/cert/cert_status_flags.h".

[wtc, 2014-03-22 01:34:41]

Sergey, I am afraid that you will need to rebase your CL because of a new
checkin: https://codereview.chromium.org/200693006/

[Sergey Ulanov, 2014-03-22 01:39:08]

The CQ bit was unchecked by sergeyu@chromium.org

[Sergey Ulanov, 2014-03-22 01:49:00]

https://codereview.chromium.org/208713004/diff/60001/chrome/browser/net/ssl_c...
File chrome/browser/net/ssl_config_service_manager_pref.cc (left):

https://codereview.chromium.org/208713004/diff/60001/chrome/browser/net/ssl_c...
chrome/browser/net/ssl_config_service_manager_pref.cc:286: config->version_max =
net::SSLConfigService::default_version_max();
On 2014/03/22 01:29:41, wtc wrote:
> 
> IMPORTANT: Are you sure these two lines can be deleted?

I think they are not necessary, but it's not relevant to this CL, so I've added
them back.

https://codereview.chromium.org/208713004/diff/60001/net/ssl/ssl_config_servi...
File net/ssl/ssl_config_service.cc (right):

https://codereview.chromium.org/208713004/diff/60001/net/ssl/ssl_config_servi...
net/ssl/ssl_config_service.cc:10: #include "net/cert/crl_set.h"
On 2014/03/22 01:29:41, wtc wrote:
> 
> Nit: "base/memory/ref_counted.h" and "net/cert/crl_set.h" are already included
> in ssl_config_service.h.

Done.

https://codereview.chromium.org/208713004/diff/60001/net/ssl/ssl_config_servi...
net/ssl/ssl_config_service.cc:14: #include <openssl/ssl.h>
On 2014/03/22 01:29:41, wtc wrote:
> 
> We should be able to remove this header.

Done.

https://codereview.chromium.org/208713004/diff/60001/net/ssl/ssl_config_servi...
File net/ssl/ssl_config_service.h (right):

https://codereview.chromium.org/208713004/diff/60001/net/ssl/ssl_config_servi...
net/ssl/ssl_config_service.h:15: #include "net/cert/cert_status_flags.h"
On 2014/03/22 01:29:41, wtc wrote:
> 
> We should be able to remove "base/basictypes.h", 
"base/strings/string_piece.h",
> and "net/cert/cert_status_flags.h".

Done.

[Sergey Ulanov, 2014-03-22 01:56:08]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2014-03-22 01:56:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/208713004/100001

[commit-bot: I haz the power, 2014-03-22 01:58:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-22 01:58:05]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[Sergey Ulanov, 2014-03-22 02:22:55]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2014-03-22 02:23:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/208713004/120001

[commit-bot: I haz the power, 2014-03-22 02:34:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-22 02:34:51]

Try jobs failed on following builders:
  tryserver.chromium on mac_chromium_rel

[Sergey Ulanov, 2014-03-23 09:29:28]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2014-03-23 09:29:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/208713004/140001

[commit-bot: I haz the power, 2014-03-24 02:32:51]

Change committed as 258843