Add upload and issue to git_cl recipe module

recipe_modules/git_cl/api.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from recipe_engine import recipe_api
 
+import string
+
+def clean_message(msg):
+  """Cleans a commit message to be able to be printed on the command line."""
+  i = 0
+  for i in range(len(msg)):

[tandrii(chromium), 2016/06/22 14:41:15]

1. Pythonic way:
  for i, c in enumerate(msg):
    if not c in string.printable
      return msg[:i]
  return msg

2. I don't see how truncating message means "cleaning".
3. If msg is a unicode string, I am not sure certain your algo is 100% working
as intended. For utf8 string, maybe, because ASCII is its subset, so utf8 has to
use first byte as '\0' for multi-byte chars. But at least document that here.
9  

[martiniss, 2016/06/22 22:47:33]

Great, thanks.
Clarified; it's not really cleaning, just making something that I can pass on
the command line.

+    if not msg[i] in string.printable:
+      break
+  if i < len(msg) - 1:
+    msg = msg[:i]
+
+  return msg
+
 class GitClApi(recipe_api.RecipeApi):
   def __call__(self, subcmd, args, name=None, **kwargs):
     if not name:
       name = 'git_cl ' + subcmd
 
     if kwargs.get('suffix'):
       name = name + ' (%s)' % kwargs.pop('suffix')
 
     if 'cwd' not in kwargs:
       kwargs['cwd'] = (self.c and self.c.repo_location) or None
@@ skipping 15 matching lines @@
     args = ['-n', '-']
     if patch or codereview:
       assert patch and codereview, "Both patch and codereview must be provided"
       args.append(patch)
       args.append('--%s' % codereview)
 
     return self(
         'description', args, stdout=self.m.raw_io.output(),
         stdin=self.m.raw_io.input(data=description),
         name='git_cl set description', **kwargs)
+
+  def upload(self, message, upload_args=None, **kwargs):
+    upload_args = upload_args or []
+    # message can have unicode, which we can't pass on the command line, so

[tandrii(chromium), 2016/06/22 14:41:15]

why not pass it in a temp file, or stdin? Patching git_cl for that is trivial.

[martiniss, 2016/06/22 22:47:33]

I do that below, in the call to set description. 

[tandrii(chromium), 2016/06/23 11:23:50]

oh, well, then why do you even need to clean the message? Just put "this message
will be overwritten later".

[martiniss, 2016/06/23 18:35:41]

It sends out an email immediately, which has the subject of the message, and
which I believe stays if you send out email later. I'll double check that
though.

[martiniss, 2016/06/23 18:44:15]

Look at https://codereview.chromium.org/2098603002. I uploaded with `git cl
upload -m "whatever"`, went online and sent a message, then did `git cl
description` and changed the message. The original title `whatever` is still
what what's used in the email, which I think we'd like to avoid.

+    # upload it separately. Get a one line message for the subject for now.
+    one_line_message = clean_message(message.split('\n')[0]) + "..."

[tandrii(chromium), 2016/06/22 14:41:15]

message.splitlines()[0]

[martiniss, 2016/06/22 22:47:34]

Done.

+
+    upload_args.extend(['-m', one_line_message])

[tandrii(chromium), 2016/06/23 11:23:50]

s/one_line_message/"whatever"

+
+    result = self('upload', upload_args, **kwargs)
+
+    # Really set the description
+    self.set_description(message)
+    return result
+
+  def issue(self, **kwargs):
+    return self('issue', [], stdout=self.m.raw_io.output(), **kwargs)
+