Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2087043004: MD Downloads: "Clear All" should remove dangerous downloads for good (Closed)

Created:
4 years, 6 months ago by Dan Beam
Modified:
4 years, 6 months ago
Reviewers:
asanka
CC:
asanka, chromium-reviews, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: "Clear All" should remove dangerous downloads for good R=asanka@chromium.org BUG=622362 Committed: https://crrev.com/a15d393a0a1760de4f8c78be9225260a9b5979c0 Cr-Commit-Position: refs/heads/master@{#401633}

Patch Set 1 #

Total comments: 1

Patch Set 2 : damn #

Patch Set 3 : hot, steaming gmock tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -13 lines) Patch
M chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.h View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc View 1 4 chunks +18 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc View 1 2 3 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Dan Beam
my test-less haiku: should i write a test? yes, but not right now; so swamped. ...
4 years, 6 months ago (2016-06-23 01:15:44 UTC) #1
Dan Beam
https://codereview.chromium.org/2087043004/diff/1/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc File chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc (left): https://codereview.chromium.org/2087043004/diff/1/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc#oldcode227 chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc:227: file->Resume(); damn, maybe i'll require a test after all...
4 years, 6 months ago (2016-06-23 01:21:13 UTC) #2
Dan Beam
come get your hot, steamin' gmock tests!
4 years, 6 months ago (2016-06-23 02:12:27 UTC) #4
asanka
lgtm
4 years, 6 months ago (2016-06-23 15:25:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087043004/60001
4 years, 6 months ago (2016-06-23 16:33:26 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 6 months ago (2016-06-23 16:58:20 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 17:03:18 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a15d393a0a1760de4f8c78be9225260a9b5979c0
Cr-Commit-Position: refs/heads/master@{#401633}

Powered by Google App Engine
This is Rietveld 408576698