Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

Issue 2087013003: Remove minimum repaint feature in layout test results (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: - Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/repaint_overlay.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
index f7bbd84a861ea1dbe6c3cc30577dee9db2ae7950..90461483932227a3663905fca00f19c0f75b0e56 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
@@ -414,7 +414,9 @@ class SingleTestRunner(object):
if expected_text:
text_output = DriverOutput(text=test_output.text, image=None, image_hash=None, audio=None)
- test_result.failures.extend(self._compare_output(expected_text_output, text_output).failures)
+ text_compare_result = self._compare_output(expected_text_output, text_output)
+ test_result.failures.extend(text_compare_result.failures)
+ test_result.has_repaint_overlay = text_compare_result.has_repaint_overlay
expected_output.text = expected_text_output.text
test_result_writer.write_test_result(self._filesystem, self._port, self._results_directory,
@@ -425,7 +427,7 @@ class SingleTestRunner(object):
reftest_type = list(set([reference_file[0] for reference_file in self._reference_files]))
return TestResult(self._test_name, test_result.failures, total_test_time,
test_result.has_stderr, reftest_type=reftest_type, pid=test_result.pid,
- references=reference_test_names)
+ references=reference_test_names, has_repaint_overlay=test_result.has_repaint_overlay)
# The returned TestResult always has 0 test_run_time. _run_reftest() calculates total_run_time from test outputs.
def _compare_output_with_reference(self, reference_driver_output, actual_driver_output, reference_filename, mismatch):
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/repaint_overlay.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698