Issue 2086993003: Fix crash bug in disassembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2086993003: Fix crash bug in disassembler. (Closed)

Created:
4 years, 6 months ago by Florian Schneider

Modified:
4 years, 6 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix crash bug in disassembler. While disassembling optimized code we print ICData which can be concurrently updated by the mutator thread. This fixes this bug by moving the disassembler invocation to a safe point. BUG=#26441 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/3d56626b2c213243293f61fa5339af053bc19e7f

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	runtime/vm/compiler.cc	View		2 chunks	+8 lines, -7 lines	0 comments	Download

Total messages: 6 (2 generated)

Florian Schneider

4 years, 6 months ago (2016-06-22 18:23:46 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
3d56626b2c213243293f61fa5339af053bc19e7f (presubmit successful).