Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issue 2086833004: Run exo_unittests in waterfall (Closed)

Created:
4 years, 6 months ago by oshima
Modified:
4 years, 6 months ago
Reviewers:
reveman, M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run exo_unittests in waterfall BUG=622398 Committed: https://crrev.com/2a44e11af606669bdc493e9b60db608b6e008589 Cr-Commit-Position: refs/heads/master@{#401650}

Patch Set 1 : Merge branch 'exo_test' into exo_test2 #

Patch Set 2 : added missing dependencies #

Patch Set 3 : disable crashing test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -6 lines) Patch
M components/exo/BUILD.gn View 1 1 chunk +12 lines, -0 lines 0 comments Download
M components/exo/display_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M components/exo/wayland/server_unittest.cc View 5 chunks +25 lines, -4 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 2 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (19 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086833004/20001
4 years, 6 months ago (2016-06-22 07:34:56 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086833004/40001
4 years, 6 months ago (2016-06-22 18:46:42 UTC) #6
oshima
reveman@ -> components/exo maruel@ -> testing/buildbot
4 years, 6 months ago (2016-06-22 20:40:12 UTC) #11
reveman
components/exo lgtm
4 years, 6 months ago (2016-06-22 20:46:37 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086833004/180001
4 years, 6 months ago (2016-06-23 15:12:31 UTC) #20
oshima
reveman@, PTAL There were a few missing dependencies for exo_unittests and disabled one crashing test ...
4 years, 6 months ago (2016-06-23 15:51:56 UTC) #21
reveman
lgtm
4 years, 6 months ago (2016-06-23 15:56:23 UTC) #22
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-23 16:23:46 UTC) #24
M-A Ruel
rs lgtm
4 years, 6 months ago (2016-06-23 17:46:44 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086833004/180001
4 years, 6 months ago (2016-06-23 17:54:44 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:180001)
4 years, 6 months ago (2016-06-23 17:59:36 UTC) #29
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 18:03:30 UTC) #31
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2a44e11af606669bdc493e9b60db608b6e008589
Cr-Commit-Position: refs/heads/master@{#401650}

Powered by Google App Engine
This is Rietveld 408576698