Chromium Code Reviews
DescriptionRevert of Use CSS pixels for scrolling tests. (patchset #2 id:20001 of https://codereview.chromium.org/2066573004/ )
Reason for revert:
Speculative revert to see if it is the cause for crbug/621489.
Original issue's description:
> Use DIP for scrolling tests.
>
> DIP stands for Device-Independent Pixel. Chrome on CrOS is configured
> with IsUseZoomForDSFEnabled. On high-end devices with high DPI display
> the return values from __GestureCommon_GetBoundingVisibleRect will be
> the number of real pixels, which causes troubles as the scrolling
> coordiates are expecting DIP.
>
> The fix here is to convert real pixel values back to DIP by dividing it
> with window.devicePixelRatio.
>
> BUG=chromium:599656
> TEST=smoothness.top_25_smooth now passes on Pixel
>
> Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/91953db7ae2b087fdc2581c39d07e3862e31fa96
TBR=oshima@chromium.org,achuith@chromium.org,bccheng@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:599656
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/d4464872051362c384127e2e21fd25557bbd8a83
Patch Set 1 #
Messages
Total messages: 19 (8 generated)
|
|||||||||||||||||||