Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2086833003: Revert of Use CSS pixels for scrolling tests. (Closed)

Created:
4 years, 6 months ago by bccheng
Modified:
4 years, 5 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org, msheets1, haddowk1
Base URL:
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Use CSS pixels for scrolling tests. (patchset #2 id:20001 of https://codereview.chromium.org/2066573004/ ) Reason for revert: Speculative revert to see if it is the cause for crbug/621489. Original issue's description: > Use DIP for scrolling tests. > > DIP stands for Device-Independent Pixel. Chrome on CrOS is configured > with IsUseZoomForDSFEnabled. On high-end devices with high DPI display > the return values from __GestureCommon_GetBoundingVisibleRect will be > the number of real pixels, which causes troubles as the scrolling > coordiates are expecting DIP. > > The fix here is to convert real pixel values back to DIP by dividing it > with window.devicePixelRatio. > > BUG=chromium:599656 > TEST=smoothness.top_25_smooth now passes on Pixel > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/91953db7ae2b087fdc2581c39d07e3862e31fa96 TBR=oshima@chromium.org,achuith@chromium.org,bccheng@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:599656 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/d4464872051362c384127e2e21fd25557bbd8a83

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M telemetry/telemetry/internal/actions/scroll.js View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
bccheng
Created Revert of Use CSS pixels for scrolling tests.
4 years, 6 months ago (2016-06-21 16:38:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086833003/1
4 years, 6 months ago (2016-06-21 16:38:43 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-21 16:38:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086833003/1
4 years, 6 months ago (2016-06-21 20:59:15 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-21 20:59:17 UTC) #9
bccheng
4 years, 6 months ago (2016-06-21 21:03:33 UTC) #12
oshima
do you need lgtm?
4 years, 6 months ago (2016-06-24 07:08:05 UTC) #13
bccheng
Yes...
4 years, 6 months ago (2016-06-24 16:21:00 UTC) #14
oystein (OOO til 10th of July)
lgtm
4 years, 5 months ago (2016-06-27 19:26:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2086833003/1
4 years, 5 months ago (2016-06-28 00:41:42 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 01:12:59 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698