chrome/browser/resources/ntp4/guest_tab.html - Issue 208683007: Update incognito and guest browsing new tab page:

Side by Side Diff: chrome/browser/resources/ntp4/guest_tab.html

Issue 208683007: Update incognito and guest browsing new tab page: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix ChromeOS build error, remove surplus font attribute Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/chromeos/guest_session_tab.html ('K') | « chrome/browser/resources/chromeos/guest_session_tab.html ('k') | chrome/browser/resources/ntp4/incognito_guest_tab.css » ('j') | chrome/browser/resources/ntp4/incognito_guest_tab.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html i18n-values="dir:textdirection;bookmarkbarattached:bookmarkbarattached">	2 <html i18n-values="dir:textdirection;bookmarkbarattached:bookmarkbarattached">

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title i18n-content="title"></title>	5 <title i18n-content="title"></title>

6 <link rel="stylesheet" href="guest_tab.css">	6 <link rel="stylesheet" href="incognito_guest_tab.css">

7 <script>	7 <script>

8 // Until themes can clear the cache, force-reload the theme stylesheet.	8 // Until themes can clear the cache, force-reload the theme stylesheet.

9 document.write('<link id="guestthemecss" rel="stylesheet" ' +	9 document.write('<link id="guestthemecss" rel="stylesheet" ' +

10 'href="chrome://theme/css/guest_new_tab_theme.css?' +	10 'href="chrome://theme/css/guest_new_tab_theme.css?' +

11 Date.now() + '">');	11 Date.now() + '">');

12 </script>	12 </script>

13 </head>	13 </head>

14 <body>	14 <body>

15 <div class="content"	15 <div class="content"

16 i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize">	16 i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize">

17 <span i18n-values=".innerHTML:content"></span>	17 <h1 i18n-content="heading"></h1>

	18 <p>

	19 <span i18n-content="message"></span>

	20 <a i18n-content="learnMore" i18n-values=".href:learnMoreLink"></a>

	21 </p>

18 </div>	22 </div>

19 </body>	23 </body>

20 <script src="chrome://resources/js/cr.js"></script>	24 <script src="chrome://resources/js/cr.js"></script>

21 <script>	25 <script>

22 cr.define('ntp', function() {	26 cr.define('ntp', function() {
	Evan Stade 2014/04/22 17:52:52 this seems overkill in this case, make it match th this seems overkill in this case, make it match the briefer version found in the otr ntp? edwardjung 2014/04/22 18:34:01 Not sure I understand, the JS used on the OTR NTP Show quoted text On 2014/04/22 17:52:52, Evan Stade wrote: > this seems overkill in this case, make it match the briefer version found in the > otr ntp? Not sure I understand, the JS used on the OTR NTP is identical, with an extra function for the bookmarks bar. Evan Stade 2014/04/22 18:35:22 sorry, guest_session_tab.html Show quoted text On 2014/04/22 18:34:01, edwardjung wrote: > On 2014/04/22 17:52:52, Evan Stade wrote: > > this seems overkill in this case, make it match the briefer version found in > the > > otr ntp? > > Not sure I understand, the JS used on the OTR NTP is identical, with an extra > function for the bookmarks bar. sorry, guest_session_tab.html edwardjung 2014/04/23 10:42:10 Done. Show quoted text On 2014/04/22 18:35:22, Evan Stade wrote: > On 2014/04/22 18:34:01, edwardjung wrote: > > On 2014/04/22 17:52:52, Evan Stade wrote: > > > this seems overkill in this case, make it match the briefer version found in > > the > > > otr ntp? > > > > Not sure I understand, the JS used on the OTR NTP is identical, with an extra > > function for the bookmarks bar. > > sorry, guest_session_tab.html Done.
23 'use strict';	27 'use strict';

24	28

25 function themeChanged() {	29 function themeChanged() {

26 document.getElementById('guestthemecss').href =	30 document.getElementById('guestthemecss').href =

27 'chrome://theme/css/guest_new_tab_theme.css?' + Date.now();	31 'chrome://theme/css/guest_new_tab_theme.css?' + Date.now();

28 }	32 }

29	33

30 return {	34 return {

31 themeChanged: themeChanged,	35 themeChanged: themeChanged,

32 };	36 };

33 });	37 });

34 </script>	38 </script>

35 </html>	39 </html>

OLD	NEW