Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/hydrogen-instructions.h

Issue 208683006: Disable dead code elimination of arguments object (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-355486.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3360 matching lines...) Expand 10 before | Expand all | Expand 10 after
3371 3371
3372 DECLARE_CONCRETE_INSTRUCTION(ArgumentsObject) 3372 DECLARE_CONCRETE_INSTRUCTION(ArgumentsObject)
3373 3373
3374 private: 3374 private:
3375 HArgumentsObject(int count, Zone* zone) 3375 HArgumentsObject(int count, Zone* zone)
3376 : HDematerializedObject(count, zone) { 3376 : HDematerializedObject(count, zone) {
3377 set_representation(Representation::Tagged()); 3377 set_representation(Representation::Tagged());
3378 SetFlag(kIsArguments); 3378 SetFlag(kIsArguments);
3379 } 3379 }
3380 3380
3381 virtual bool IsDeletable() const V8_FINAL V8_OVERRIDE { return true; } 3381 virtual bool IsDeletable() const V8_FINAL V8_OVERRIDE { return false; }
Michael Starzinger 2014/04/07 07:46:24 nit: This is the default implementation in HValue,
Jarin 2014/04/07 08:40:59 Done.
3382 }; 3382 };
3383 3383
3384 3384
3385 class HCapturedObject V8_FINAL : public HDematerializedObject { 3385 class HCapturedObject V8_FINAL : public HDematerializedObject {
3386 public: 3386 public:
3387 HCapturedObject(int length, int id, Zone* zone) 3387 HCapturedObject(int length, int id, Zone* zone)
3388 : HDematerializedObject(length, zone), capture_id_(id) { 3388 : HDematerializedObject(length, zone), capture_id_(id) {
3389 set_representation(Representation::Tagged()); 3389 set_representation(Representation::Tagged());
3390 values_.AddBlock(NULL, length, zone); // Resize list. 3390 values_.AddBlock(NULL, length, zone); // Resize list.
3391 } 3391 }
(...skipping 4127 matching lines...) Expand 10 before | Expand all | Expand 10 after
7519 virtual bool IsDeletable() const V8_OVERRIDE { return true; } 7519 virtual bool IsDeletable() const V8_OVERRIDE { return true; }
7520 }; 7520 };
7521 7521
7522 7522
7523 #undef DECLARE_INSTRUCTION 7523 #undef DECLARE_INSTRUCTION
7524 #undef DECLARE_CONCRETE_INSTRUCTION 7524 #undef DECLARE_CONCRETE_INSTRUCTION
7525 7525
7526 } } // namespace v8::internal 7526 } } // namespace v8::internal
7527 7527
7528 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 7528 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-355486.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698