Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2086813002: X87: Remove more dead code now that legacy const is gone. (Closed)

Created:
4 years, 6 months ago by zhengxing.li
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Remove more dead code now that legacy const is gone. port 757221e574ecba543a65f4822c083aa860e030eb(r36876) original commit message: Neither globals nor lookup slots can be hole-initialized anymore, thus removing some dead code from the code generators and runtime-scopes. BUG= Committed: https://crrev.com/42880af7059ec002aa013a8740232d54839dbbf3 Cr-Commit-Position: refs/heads/master@{#37127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 6 months ago (2016-06-21 06:15:41 UTC) #2
Weiliang
lgtm
4 years, 6 months ago (2016-06-21 06:20:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086813002/1
4 years, 6 months ago (2016-06-21 06:21:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 06:44:50 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 06:45:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42880af7059ec002aa013a8740232d54839dbbf3
Cr-Commit-Position: refs/heads/master@{#37127}

Powered by Google App Engine
This is Rietveld 408576698