Make per-file OWNERS rules for files involved in IPC consistent.

Make per-file OWNERS rules for files involved in IPC consistent.

The new PRESUBMIT checks landed in https://codereview.chromium.org/2070483002
now expect that files involved in IPC are covered by the appropriate per-file
OWNERS rules that delegate to /ipc/SECURITY_OWNERS.

However, the PRESUBMIT script requires that, e.g., files matching the pattern
"*_messages*.h*" are covered by the rules:
  per-file *_messages*.h=set noparent
  per-file *_messages*.h=file://ipc/SECURITY_OWNERS,
and not, e.g., by rules containing the glob "*message*". There are a couple of
more predefined globs in the PRESUBMIT script.

This CL refactors existing per-file OWNERS rules referencing files involved in
IPC to consistently use the exact glob patterns as are defined in the PRESUBMIT
script.

This will avoid PRESUBMIT check failures when IPC messages are modified for the
first time in the affected components, and spare respective OWNERS the
headache.

BUG=611905
TBR=jam@chromium.org

Committed: https://crrev.com/520de0f3c981d36cc59acd3afbb8484d1c0ecff2
Cr-Commit-Position: refs/heads/master@{#400967}

[engedy, 2016-06-21 09:20:43]

Description was changed from

==========
Fix typos in IPC message OWNERS files causing PRESUBMIT check failures.

The new PRESUBMIT checks landed in https://codereview.chromium.org/2070483002
now expect, among other things, that IPC message declarations are accompanied
by an OWNERS files containing the pattern "*_messages*.h*". However, in 4 of
the many refactored OWNERS files, the same CL accidentally added the pattern
"*messages*.h" instead (note the lack of underscore).

One file has already been fixed, this CL fixes the remaining three files to
spare respective OWNERS the headache.

BUG=611905
==========

to

==========
Fix typos in some IPC message OWNERS files causing PRESUBMIT check failures.

The new PRESUBMIT checks landed in https://codereview.chromium.org/2070483002
now expect, among other things, that IPC message declarations are accompanied
by an OWNERS files containing the pattern "*_messages*.h*". However, in 4 of
the many refactored OWNERS files, the same CL mistakenly added the pattern
"*messages*.h" instead (note the lack of underscore).

This will lead to PRESUBMIT check failures when IPC messages are modified for 
the first time in the affected components. One file has already been fixed,
this CL fixes the remaining three files to spare respective OWNERS the
headache.

BUG=611905
==========

[engedy, 2016-06-21 09:20:43]

engedy@chromium.org changed reviewers:
+ jam@chromium.org

[engedy, 2016-06-21 09:24:35]

engedy@chromium.org changed reviewers:
+ dcheng@chromium.org

[engedy, 2016-06-21 09:24:50]

@Daniel, John, please take a look.

[dcheng, 2016-06-21 11:16:17]

LGTM, thanks... not sure why my grep on the diff missed these matches =(

[engedy, 2016-06-21 11:53:37]

Description was changed from

==========
Fix typos in some IPC message OWNERS files causing PRESUBMIT check failures.

The new PRESUBMIT checks landed in https://codereview.chromium.org/2070483002
now expect, among other things, that IPC message declarations are accompanied
by an OWNERS files containing the pattern "*_messages*.h*". However, in 4 of
the many refactored OWNERS files, the same CL mistakenly added the pattern
"*messages*.h" instead (note the lack of underscore).

This will lead to PRESUBMIT check failures when IPC messages are modified for 
the first time in the affected components. One file has already been fixed,
this CL fixes the remaining three files to spare respective OWNERS the
headache.

BUG=611905
==========

to

==========
Make per-file OWNERS rules for files involved in IPC consistent.

The new PRESUBMIT checks landed in https://codereview.chromium.org/2070483002
now expect that files involved in IPC are covered by the appropriate per-file
OWNERS rules that delegate to /ipc/SECURITY_OWNERS.

However, the PRESUBMIT script requires that, e.g., files matching the pattern
"*_messages*.h*" are covered by the rules:
  per-file *_message*.h=set noparent
  per-file *_message*.h=file://ipc/SECURITY_OWNERS,
and not, e.g., by rules containing the glob "*messages*". There are a couple of
more predefined globs in the PRESUBMIT script.

This CL refactors existing per-file OWNERS rules referencing files involved in
IPC to consistently use the exact glob patterns that are defined in the
PRESUBMIT script.

This will avoid PRESUBMIT check failures when IPC messages are modified for the
first time in the affected components, and spare respective OWNERS the
headache.

BUG=611905
==========

[engedy, 2016-06-21 11:53:53]

Description was changed from

==========
Make per-file OWNERS rules for files involved in IPC consistent.

The new PRESUBMIT checks landed in https://codereview.chromium.org/2070483002
now expect that files involved in IPC are covered by the appropriate per-file
OWNERS rules that delegate to /ipc/SECURITY_OWNERS.

However, the PRESUBMIT script requires that, e.g., files matching the pattern
"*_messages*.h*" are covered by the rules:
  per-file *_message*.h=set noparent
  per-file *_message*.h=file://ipc/SECURITY_OWNERS,
and not, e.g., by rules containing the glob "*messages*". There are a couple of
more predefined globs in the PRESUBMIT script.

This CL refactors existing per-file OWNERS rules referencing files involved in
IPC to consistently use the exact glob patterns that are defined in the
PRESUBMIT script.

This will avoid PRESUBMIT check failures when IPC messages are modified for the
first time in the affected components, and spare respective OWNERS the
headache.

BUG=611905
==========

to

==========
Make per-file OWNERS rules for files involved in IPC consistent.

The new PRESUBMIT checks landed in https://codereview.chromium.org/2070483002
now expect that files involved in IPC are covered by the appropriate per-file
OWNERS rules that delegate to /ipc/SECURITY_OWNERS.

However, the PRESUBMIT script requires that, e.g., files matching the pattern
"*_messages*.h*" are covered by the rules:
  per-file *_message*.h=set noparent
  per-file *_message*.h=file://ipc/SECURITY_OWNERS,
and not, e.g., by rules containing the glob "*messages*". There are a couple of
more predefined globs in the PRESUBMIT script.

This CL refactors existing per-file OWNERS rules referencing files involved in
IPC to consistently use the exact glob patterns that are defined in the
PRESUBMIT script.

This will avoid PRESUBMIT check failures when IPC messages are modified for the
first time in the affected components, and spare respective OWNERS the
headache.

BUG=611905
TBR=jam@chromium.org
==========

[engedy, 2016-06-21 11:54:54]

Description was changed from

==========
Make per-file OWNERS rules for files involved in IPC consistent.

The new PRESUBMIT checks landed in https://codereview.chromium.org/2070483002
now expect that files involved in IPC are covered by the appropriate per-file
OWNERS rules that delegate to /ipc/SECURITY_OWNERS.

However, the PRESUBMIT script requires that, e.g., files matching the pattern
"*_messages*.h*" are covered by the rules:
  per-file *_message*.h=set noparent
  per-file *_message*.h=file://ipc/SECURITY_OWNERS,
and not, e.g., by rules containing the glob "*messages*". There are a couple of
more predefined globs in the PRESUBMIT script.

This CL refactors existing per-file OWNERS rules referencing files involved in
IPC to consistently use the exact glob patterns that are defined in the
PRESUBMIT script.

This will avoid PRESUBMIT check failures when IPC messages are modified for the
first time in the affected components, and spare respective OWNERS the
headache.

BUG=611905
TBR=jam@chromium.org
==========

to

==========
Make per-file OWNERS rules for files involved in IPC consistent.

The new PRESUBMIT checks landed in https://codereview.chromium.org/2070483002
now expect that files involved in IPC are covered by the appropriate per-file
OWNERS rules that delegate to /ipc/SECURITY_OWNERS.

However, the PRESUBMIT script requires that, e.g., files matching the pattern
"*_messages*.h*" are covered by the rules:
  per-file *_messages*.h=set noparent
  per-file *_messages*.h=file://ipc/SECURITY_OWNERS,
and not, e.g., by rules containing the glob "*message*". There are a couple of
more predefined globs in the PRESUBMIT script.

This CL refactors existing per-file OWNERS rules referencing files involved in
IPC to consistently use the exact glob patterns that are defined in the
PRESUBMIT script.

This will avoid PRESUBMIT check failures when IPC messages are modified for the
first time in the affected components, and spare respective OWNERS the
headache.

BUG=611905
TBR=jam@chromium.org
==========

[engedy, 2016-06-21 11:55:42]

Description was changed from

==========
Make per-file OWNERS rules for files involved in IPC consistent.

The new PRESUBMIT checks landed in https://codereview.chromium.org/2070483002
now expect that files involved in IPC are covered by the appropriate per-file
OWNERS rules that delegate to /ipc/SECURITY_OWNERS.

However, the PRESUBMIT script requires that, e.g., files matching the pattern
"*_messages*.h*" are covered by the rules:
  per-file *_messages*.h=set noparent
  per-file *_messages*.h=file://ipc/SECURITY_OWNERS,
and not, e.g., by rules containing the glob "*message*". There are a couple of
more predefined globs in the PRESUBMIT script.

This CL refactors existing per-file OWNERS rules referencing files involved in
IPC to consistently use the exact glob patterns that are defined in the
PRESUBMIT script.

This will avoid PRESUBMIT check failures when IPC messages are modified for the
first time in the affected components, and spare respective OWNERS the
headache.

BUG=611905
TBR=jam@chromium.org
==========

to

==========
Make per-file OWNERS rules for files involved in IPC consistent.

The new PRESUBMIT checks landed in https://codereview.chromium.org/2070483002
now expect that files involved in IPC are covered by the appropriate per-file
OWNERS rules that delegate to /ipc/SECURITY_OWNERS.

However, the PRESUBMIT script requires that, e.g., files matching the pattern
"*_messages*.h*" are covered by the rules:
  per-file *_messages*.h=set noparent
  per-file *_messages*.h=file://ipc/SECURITY_OWNERS,
and not, e.g., by rules containing the glob "*message*". There are a couple of
more predefined globs in the PRESUBMIT script.

This CL refactors existing per-file OWNERS rules referencing files involved in
IPC to consistently use the exact glob patterns as are defined in the PRESUBMIT
script.

This will avoid PRESUBMIT check failures when IPC messages are modified for the
first time in the affected components, and spare respective OWNERS the
headache.

BUG=611905
TBR=jam@chromium.org
==========

[engedy, 2016-06-21 11:56:26]

The CQ bit was checked by engedy@chromium.org

[engedy, 2016-06-21 11:56:27]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2086803003/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-06-21 11:56:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2086803003/60001

[engedy, 2016-06-21 11:59:04]

@John, with Daniel having reviewed I am TBR'ing you so that the fix can go in
ASAP, as I have already heard some people around me being puzzled about the
PRESUBMIT failures.

[engedy, 2016-06-21 12:02:02]

I have used the below command to verify that patterns appearing in per-file
rules are either (1) using one of the globs defined in |file_patterns| of the
PRESUBMIT script, or (2) do not match those globs at all:

diff --unified=0 <(git grep "per-file .*=file://ipc/SECURITY_OWNERS" | grep -oP
"per-file \K[^=]*" | sort | uniq) <(cat ../file_patterns.txt | sort)

@@ -1,5 +0,0 @@
-chrome_content_utility_ipc_whitelist.cc
-devtools_embedder_message_dispatcher.*
-*font_config_ipc_linux*
-ipc_message_start.h
-*_message_param*.*
@@ -10,2 +4,0 @@
-*protobuf_message*.h
-%s
@@ -14,0 +8 @@
+*TypeConverter*.*

[engedy, 2016-06-21 12:04:45]

Finally, to verify that this CL does not change SECURITY_OWNERS coverage --
modulo the files below that, I believe, did not need to be covered anyway -- I
used the following script:

function coverage {
  for owners_file in $(git diff origin/master --name-only); do
    globs=$(git diff origin/master $owners_file | grep -oP "^$1per-file
\K[^=]*")
    for glob in ${globs}; do
      git ls-files "$(dirname $owners_file)/${glob}"
    done
  done
}

diff --unified=0 <(coverage "-" | sort | uniq) <(coverage "\+" | sort | uniq)

Output:
@@ -1 +0,0 @@
-chromecast/common/media/cast_message_generator.h
@@ -3 +1,0 @@
-chromecast/common/media/cma_message_generator.h
@@ -37 +34,0 @@
-ui/gfx/mojo/struct_traits_unittest.cc

[commit-bot: I haz the power, 2016-06-21 12:39:49]

Description was changed from

==========
Make per-file OWNERS rules for files involved in IPC consistent.

The new PRESUBMIT checks landed in https://codereview.chromium.org/2070483002
now expect that files involved in IPC are covered by the appropriate per-file
OWNERS rules that delegate to /ipc/SECURITY_OWNERS.

However, the PRESUBMIT script requires that, e.g., files matching the pattern
"*_messages*.h*" are covered by the rules:
  per-file *_messages*.h=set noparent
  per-file *_messages*.h=file://ipc/SECURITY_OWNERS,
and not, e.g., by rules containing the glob "*message*". There are a couple of
more predefined globs in the PRESUBMIT script.

This CL refactors existing per-file OWNERS rules referencing files involved in
IPC to consistently use the exact glob patterns as are defined in the PRESUBMIT
script.

This will avoid PRESUBMIT check failures when IPC messages are modified for the
first time in the affected components, and spare respective OWNERS the
headache.

BUG=611905
TBR=jam@chromium.org
==========

to

==========
Make per-file OWNERS rules for files involved in IPC consistent.

The new PRESUBMIT checks landed in https://codereview.chromium.org/2070483002
now expect that files involved in IPC are covered by the appropriate per-file
OWNERS rules that delegate to /ipc/SECURITY_OWNERS.

However, the PRESUBMIT script requires that, e.g., files matching the pattern
"*_messages*.h*" are covered by the rules:
  per-file *_messages*.h=set noparent
  per-file *_messages*.h=file://ipc/SECURITY_OWNERS,
and not, e.g., by rules containing the glob "*message*". There are a couple of
more predefined globs in the PRESUBMIT script.

This CL refactors existing per-file OWNERS rules referencing files involved in
IPC to consistently use the exact glob patterns as are defined in the PRESUBMIT
script.

This will avoid PRESUBMIT check failures when IPC messages are modified for the
first time in the affected components, and spare respective OWNERS the
headache.

BUG=611905
TBR=jam@chromium.org
==========

[commit-bot: I haz the power, 2016-06-21 12:39:51]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-21 12:41:28]

Description was changed from

==========
Make per-file OWNERS rules for files involved in IPC consistent.

The new PRESUBMIT checks landed in https://codereview.chromium.org/2070483002
now expect that files involved in IPC are covered by the appropriate per-file
OWNERS rules that delegate to /ipc/SECURITY_OWNERS.

However, the PRESUBMIT script requires that, e.g., files matching the pattern
"*_messages*.h*" are covered by the rules:
  per-file *_messages*.h=set noparent
  per-file *_messages*.h=file://ipc/SECURITY_OWNERS,
and not, e.g., by rules containing the glob "*message*". There are a couple of
more predefined globs in the PRESUBMIT script.

This CL refactors existing per-file OWNERS rules referencing files involved in
IPC to consistently use the exact glob patterns as are defined in the PRESUBMIT
script.

This will avoid PRESUBMIT check failures when IPC messages are modified for the
first time in the affected components, and spare respective OWNERS the
headache.

BUG=611905
TBR=jam@chromium.org
==========

to

==========
Make per-file OWNERS rules for files involved in IPC consistent.

The new PRESUBMIT checks landed in https://codereview.chromium.org/2070483002
now expect that files involved in IPC are covered by the appropriate per-file
OWNERS rules that delegate to /ipc/SECURITY_OWNERS.

However, the PRESUBMIT script requires that, e.g., files matching the pattern
"*_messages*.h*" are covered by the rules:
  per-file *_messages*.h=set noparent
  per-file *_messages*.h=file://ipc/SECURITY_OWNERS,
and not, e.g., by rules containing the glob "*message*". There are a couple of
more predefined globs in the PRESUBMIT script.

This CL refactors existing per-file OWNERS rules referencing files involved in
IPC to consistently use the exact glob patterns as are defined in the PRESUBMIT
script.

This will avoid PRESUBMIT check failures when IPC messages are modified for the
first time in the affected components, and spare respective OWNERS the
headache.

BUG=611905
TBR=jam@chromium.org

Committed: https://crrev.com/520de0f3c981d36cc59acd3afbb8484d1c0ecff2
Cr-Commit-Position: refs/heads/master@{#400967}
==========

[commit-bot: I haz the power, 2016-06-21 12:41:29]

Patchset 4 (id:??) landed as
https://crrev.com/520de0f3c981d36cc59acd3afbb8484d1c0ecff2
Cr-Commit-Position: refs/heads/master@{#400967}