Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3570)

Unified Diff: chrome/browser/ui/webui/ntp/app_launcher_handler.h

Issue 2086763002: Don't use deprecated ListValue::Append(Value*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/app_launcher_handler.h
diff --git a/chrome/browser/ui/webui/ntp/app_launcher_handler.h b/chrome/browser/ui/webui/ntp/app_launcher_handler.h
index f774923ee6cd7a488fad42e6e3de1096ae9e3cb7..b1ddc870f05610195b0f47856e3836f61647c227 100644
--- a/chrome/browser/ui/webui/ntp/app_launcher_handler.h
+++ b/chrome/browser/ui/webui/ntp/app_launcher_handler.h
@@ -83,10 +83,10 @@ class AppLauncherHandler
// Populate the given dictionary with all installed app info.
void FillAppDictionary(base::DictionaryValue* value);
- // Create a dictionary value for the given extension. May return NULL, e.g. if
- // the given extension is not an app. If non-NULL, the caller assumes
- // ownership of the pointer.
- base::DictionaryValue* GetAppInfo(const extensions::Extension* extension);
+ // Create a dictionary value for the given extension. May return null, e.g. if
+ // the given extension is not an app.
+ std::unique_ptr<base::DictionaryValue> GetAppInfo(
+ const extensions::Extension* extension);
// Populate the given dictionary with the web store promo content.
void FillPromoDictionary(base::DictionaryValue* value);

Powered by Google App Engine
This is Rietveld 408576698