Don't use deprecated ListValue::Append(Value*) overload.

chrome/browser/ui/webui/options/handler_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/handler_options_handler.h"
 
 #include <memory>
 #include <utility>
 #include <vector>
 
@@ skipping 73 matching lines @@
 ProtocolHandlerRegistry* HandlerOptionsHandler::GetProtocolHandlerRegistry() {
   return ProtocolHandlerRegistryFactory::GetForBrowserContext(
       Profile::FromWebUI(web_ui()));
 }
 
 static void GetHandlersAsListValue(
     const ProtocolHandlerRegistry::ProtocolHandlerList& handlers,
     base::ListValue* handler_list) {
   ProtocolHandlerRegistry::ProtocolHandlerList::const_iterator handler;
   for (handler = handlers.begin(); handler != handlers.end(); ++handler) {
-    std::unique_ptr<base::ListValue> handlerValue(new base::ListValue());
-    handlerValue->AppendString(handler->protocol());
-    handlerValue->AppendString(handler->url().spec());
-    handlerValue->AppendString(handler->url().host());
-    handler_list->Append(std::move(handlerValue));
+    std::unique_ptr<base::ListValue> handler_value(new base::ListValue());
+    handler_value->AppendString(handler->protocol());
+    handler_value->AppendString(handler->url().spec());
+    handler_value->AppendString(handler->url().host());
+    handler_list->Append(std::move(handler_value));
   }
 }
 
 void HandlerOptionsHandler::GetHandlersForProtocol(
     const std::string& protocol,
     base::DictionaryValue* handlers_value) {
   ProtocolHandlerRegistry* registry = GetProtocolHandlerRegistry();
   // The items which are to be written into |handlers_value| are also described
   // in chrome/browser/resources/options/handler_options.js in @typedef
   // for Handlers. Please update them whenever you add or remove any keys here.
@@ skipping 19 matching lines @@
 }
 
 void HandlerOptionsHandler::UpdateHandlerList() {
   ProtocolHandlerRegistry* registry = GetProtocolHandlerRegistry();
   std::vector<std::string> protocols;
   registry->GetRegisteredProtocols(&protocols);
 
   base::ListValue handlers;
   for (std::vector<std::string>::iterator protocol = protocols.begin();
        protocol != protocols.end(); protocol++) {
-    base::DictionaryValue* handler_value = new base::DictionaryValue();
-    GetHandlersForProtocol(*protocol, handler_value);
-    handlers.Append(handler_value);
+    std::unique_ptr<base::DictionaryValue> handler_value(
+        new base::DictionaryValue());
+    GetHandlersForProtocol(*protocol, handler_value.get());
+    handlers.Append(std::move(handler_value));
   }
 
   std::unique_ptr<base::ListValue> ignored_handlers(new base::ListValue());
   GetIgnoredHandlers(ignored_handlers.get());
   web_ui()->CallJavascriptFunctionUnsafe("HandlerOptions.setHandlers",
                                          handlers);
   web_ui()->CallJavascriptFunctionUnsafe("HandlerOptions.setIgnoredHandlers",
                                          *ignored_handlers);
 }
 
@@ skipping 61 matching lines @@
 
 void HandlerOptionsHandler::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   DCHECK_EQ(chrome::NOTIFICATION_PROTOCOL_HANDLER_REGISTRY_CHANGED, type);
   UpdateHandlerList();
 }
 
 }  // namespace options