Don't use deprecated ListValue::Append(Value*) overload.

chrome/browser/ui/webui/ntp/app_launcher_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/ntp/app_launcher_handler.h"
 
 #include <stddef.h>
 
 #include <vector>
 
@@ skipping 361 matching lines @@
 
   base::ListValue* list = new base::ListValue();
   Profile* profile = Profile::FromWebUI(web_ui());
   PrefService* prefs = profile->GetPrefs();
 
   for (std::set<std::string>::iterator it = visible_apps_.begin();
        it != visible_apps_.end(); ++it) {
     const Extension* extension = extension_service_->GetInstalledExtension(*it);
     if (extension && extensions::ui_util::ShouldDisplayInNewTabPage(
             extension, profile)) {
-      base::DictionaryValue* app_info = GetAppInfo(extension);
-      list->Append(app_info);
+      list->Append(GetAppInfo(extension));
     }
   }
 
   dictionary->Set("apps", list);
 
   const base::ListValue* app_page_names =
       prefs->GetList(prefs::kNtpAppPageNames);
   if (!app_page_names || !app_page_names->GetSize()) {
     ListPrefUpdate update(prefs, prefs::kNtpAppPageNames);
     base::ListValue* list = update.Get();
     list->Set(0, new base::StringValue(
         l10n_util::GetStringUTF16(IDS_APP_DEFAULT_PAGE_NAME)));
     dictionary->Set("appPageNames",
                     static_cast<base::ListValue*>(list->DeepCopy()));
   } else {
     dictionary->Set("appPageNames",
                     static_cast<base::ListValue*>(app_page_names->DeepCopy()));
   }
 }
 
-base::DictionaryValue* AppLauncherHandler::GetAppInfo(
+std::unique_ptr<base::DictionaryValue> AppLauncherHandler::GetAppInfo(
     const Extension* extension) {
-  base::DictionaryValue* app_info = new base::DictionaryValue();
+  std::unique_ptr<base::DictionaryValue> app_info(new base::DictionaryValue());
   // CreateAppInfo can change the extension prefs.
   base::AutoReset<bool> auto_reset(&ignore_changes_, true);
-  CreateAppInfo(extension,
-                extension_service_,
-                app_info);
+  CreateAppInfo(extension, extension_service_, app_info.get());
   return app_info;
 }
 
 void AppLauncherHandler::HandleGetApps(const base::ListValue* args) {
   base::DictionaryValue dictionary;
 
   // Tell the client whether to show the promo for this view. We don't do this
   // in the case of PREF_CHANGED because:
   //
   // a) At that point in time, depending on the pref that changed, it can look
@@ skipping 460 matching lines @@
       base::FundamentalValue(!extension_id_prompting_.empty()));
 }
 
 bool AppLauncherHandler::ShouldShow(const Extension* extension) const {
   if (ignore_changes_ || !has_loaded_apps_ || !extension->is_app())
     return false;
 
   Profile* profile = Profile::FromWebUI(web_ui());
   return extensions::ui_util::ShouldDisplayInNewTabPage(extension, profile);
 }