Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5348)

Unified Diff: chrome/browser/android/offline_pages/recent_tab_helper.cc

Issue 2086733002: [Offline Pages] Fix cases where returning NOT_FOUND when deleting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/recent_tab_helper.cc
diff --git a/chrome/browser/android/offline_pages/recent_tab_helper.cc b/chrome/browser/android/offline_pages/recent_tab_helper.cc
index b002ea80d77bf69f619232071ca070b584a9c914..6081dac07565436e825852c998d5f34d97145ea2 100644
--- a/chrome/browser/android/offline_pages/recent_tab_helper.cc
+++ b/chrome/browser/android/offline_pages/recent_tab_helper.cc
@@ -152,10 +152,7 @@ void RecentTabHelper::ContinueSnapshotWithIdsToPurge(
void RecentTabHelper::ContinueSnapshotAfterPurge(
OfflinePageModel::DeletePageResult result) {
- // NOT_FOUND is because it's what we get when passing empty vector of ids.
- // TODO(dimich): remove NOT_FOUND when bug 608057 is fixed.
- if (result != OfflinePageModel::DeletePageResult::SUCCESS &&
- result != OfflinePageModel::DeletePageResult::NOT_FOUND) {
+ if (result != OfflinePageModel::DeletePageResult::SUCCESS) {
// If previous pages can't be deleted, don't add new ones.
ReportSnapshotCompleted();
return;

Powered by Google App Engine
This is Rietveld 408576698