Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 20867003: More cleanup regarding the maximum non-large object allocation size. (Closed)

Created:
7 years, 4 months ago by Hannes Payer (out of office)
Modified:
7 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

More cleanup regarding the maximum non-large object allocation size. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16052

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -36 lines) Patch
M src/heap.cc View 1 2 3 11 chunks +16 lines, -31 lines 0 comments Download
M src/objects-visiting.h View 1 chunk +1 line, -1 line 0 comments Download
M src/spaces.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hannes Payer (out of office)
7 years, 4 months ago (2013-08-01 16:51:45 UTC) #1
Michael Starzinger
Looking good, just one comment. https://codereview.chromium.org/20867003/diff/3001/src/spaces.h File src/spaces.h (right): https://codereview.chromium.org/20867003/diff/3001/src/spaces.h#newcode783 src/spaces.h:783: kPageSize - kObjectStartOffset - ...
7 years, 4 months ago (2013-08-02 12:30:53 UTC) #2
Michael Starzinger
LGTM after previous comment is addressed.
7 years, 4 months ago (2013-08-02 12:31:17 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/20867003/diff/3001/src/spaces.h File src/spaces.h (right): https://codereview.chromium.org/20867003/diff/3001/src/spaces.h#newcode783 src/spaces.h:783: kPageSize - kObjectStartOffset - kPointerSize; On 2013/08/02 12:30:53, Michael ...
7 years, 4 months ago (2013-08-05 12:52:21 UTC) #4
Hannes Payer (out of office)
7 years, 4 months ago (2013-08-05 12:53:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r16052 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698