Use fixed logical height in LayoutMenuList

Use fixed logical height in LayoutMenuList based on style()->getFontMetrics().height(). That's consistent with the logic that is used to calculate height for other layout objects inherited from InlineBox.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/line/InlineBox.cpp?rcl=0&l=150

This reverts the logic introduced in 4681903723a0df535a60069ec9f7d6ea21fe69d0 where LayoutMenuList logical height was based on the max option height. The reason for revert is that 1) the change broke many websites CSS as they rely on thee fixed height of HTML select element 2) Other browsers including Edge/IE use fixed HTML select's height.

TestExpectations is updated to mark all "NeedsRebaseline" tests as "NeedsManualRebaseline". They be deleted after 26c47e86c793250445a4b9c0464249fb29932768 rollback is landed.

BUG=484632
Committed: https://crrev.com/c2a23354aee0beef71541680def441d025dc37b9
Cr-Commit-Position: refs/heads/master@{#402211}

[Gleb Lanbin, 2016-06-23 17:34:31]

Description was changed from

==========
Use fixed logical height in LayoutMenuList

BUG=484632
==========

to

==========
Use fixed logical height in LayoutMenuList based on
style()->getFontMetrics().height(). That's consistent with the logic that is
used to calculate height for other layout objects inherited from InlineBox. 
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/li...

This reverts the logic introduced in 4681903723a0df535a60069ec9f7d6ea21fe69d0
where LayoutMenuList logical height was based on the max option height. The
reason for revert is that 1) the change broke many websites CSS as they rely on
thee fixed height of HTML select element 2) Other browsers including Edge/IE use
fixed HTML select's height.

TestExpectations is updated to mark all "NeedsRebaseline" tests as
"NeedsManualRebaseline". They be deleted after
26c47e86c793250445a4b9c0464249fb29932768 rollback is landed.

BUG=484632
==========

[Gleb Lanbin, 2016-06-23 17:36:14]

glebl@chromium.org changed reviewers:
+ eae@chromium.org

[eae, 2016-06-27 15:59:38]

OK, LGTM

[eae, 2016-06-27 15:59:44]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-06-27 16:00:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 17:21:59]

Description was changed from

==========
Use fixed logical height in LayoutMenuList based on
style()->getFontMetrics().height(). That's consistent with the logic that is
used to calculate height for other layout objects inherited from InlineBox. 
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/li...

This reverts the logic introduced in 4681903723a0df535a60069ec9f7d6ea21fe69d0
where LayoutMenuList logical height was based on the max option height. The
reason for revert is that 1) the change broke many websites CSS as they rely on
thee fixed height of HTML select element 2) Other browsers including Edge/IE use
fixed HTML select's height.

TestExpectations is updated to mark all "NeedsRebaseline" tests as
"NeedsManualRebaseline". They be deleted after
26c47e86c793250445a4b9c0464249fb29932768 rollback is landed.

BUG=484632
==========

to

==========
Use fixed logical height in LayoutMenuList based on
style()->getFontMetrics().height(). That's consistent with the logic that is
used to calculate height for other layout objects inherited from InlineBox. 
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/li...

This reverts the logic introduced in 4681903723a0df535a60069ec9f7d6ea21fe69d0
where LayoutMenuList logical height was based on the max option height. The
reason for revert is that 1) the change broke many websites CSS as they rely on
thee fixed height of HTML select element 2) Other browsers including Edge/IE use
fixed HTML select's height.

TestExpectations is updated to mark all "NeedsRebaseline" tests as
"NeedsManualRebaseline". They be deleted after
26c47e86c793250445a4b9c0464249fb29932768 rollback is landed.

BUG=484632
==========

[commit-bot: I haz the power, 2016-06-27 17:22:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-27 17:23:16]

Description was changed from

==========
Use fixed logical height in LayoutMenuList based on
style()->getFontMetrics().height(). That's consistent with the logic that is
used to calculate height for other layout objects inherited from InlineBox. 
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/li...

This reverts the logic introduced in 4681903723a0df535a60069ec9f7d6ea21fe69d0
where LayoutMenuList logical height was based on the max option height. The
reason for revert is that 1) the change broke many websites CSS as they rely on
thee fixed height of HTML select element 2) Other browsers including Edge/IE use
fixed HTML select's height.

TestExpectations is updated to mark all "NeedsRebaseline" tests as
"NeedsManualRebaseline". They be deleted after
26c47e86c793250445a4b9c0464249fb29932768 rollback is landed.

BUG=484632
==========

to

==========
Use fixed logical height in LayoutMenuList based on
style()->getFontMetrics().height(). That's consistent with the logic that is
used to calculate height for other layout objects inherited from InlineBox.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/li...

This reverts the logic introduced in 4681903723a0df535a60069ec9f7d6ea21fe69d0
where LayoutMenuList logical height was based on the max option height. The
reason for revert is that 1) the change broke many websites CSS as they rely on
thee fixed height of HTML select element 2) Other browsers including Edge/IE use
fixed HTML select's height.

TestExpectations is updated to mark all "NeedsRebaseline" tests as
"NeedsManualRebaseline". They be deleted after
26c47e86c793250445a4b9c0464249fb29932768 rollback is landed.

BUG=484632

Committed: https://crrev.com/c2a23354aee0beef71541680def441d025dc37b9
Cr-Commit-Position: refs/heads/master@{#402211}
==========

[commit-bot: I haz the power, 2016-06-27 17:23:17]

Patchset 1 (id:??) landed as
https://crrev.com/c2a23354aee0beef71541680def441d025dc37b9
Cr-Commit-Position: refs/heads/master@{#402211}

[mstensho (USE GERRIT), 2016-08-18 08:46:53]

mstensho@opera.com changed reviewers:
+ mstensho@opera.com

[mstensho (USE GERRIT), 2016-08-18 08:46:54]

In the future, could you please wrap lines in commit messages a little?

---------
The first line in the commit message should be a brief description.

After a blank line, add as much explanation as necessary, but be sure
to wrap lines. I think the norm is to wrap before you reach 80
characters on a line, or even a few characters before that.

Thank you! :)
----------