Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2086663006: Don't sync kEnableContinuousSpellcheck to mobile platforms. (Closed)

Created:
4 years, 6 months ago by melandory
Modified:
4 years, 6 months ago
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't sync kEnableContinuousSpellcheck to mobile platforms. Chrome will start sync prefs on mobile. It's not desired behaviour for the kEnableContinuousSpellcheck. BUG=622620 Committed: https://crrev.com/760a953ded79dfb404f381eba21efd9c7d10b6e6 Cr-Commit-Position: refs/heads/master@{#401740}

Patch Set 1 #

Patch Set 2 : Don't sync kEnableContinuousSpellcheck to mobile platforms. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/browser/spellchecker/spellcheck_factory.cc View 1 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
melandory
4 years, 6 months ago (2016-06-23 08:41:32 UTC) #3
melandory
PTAL, thanks!
4 years, 6 months ago (2016-06-23 08:41:50 UTC) #4
please use gerrit instead
lgtm
4 years, 6 months ago (2016-06-23 15:31:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086663006/20001
4 years, 6 months ago (2016-06-23 21:59:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-23 22:04:23 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 22:06:55 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/760a953ded79dfb404f381eba21efd9c7d10b6e6
Cr-Commit-Position: refs/heads/master@{#401740}

Powered by Google App Engine
This is Rietveld 408576698