Issue 2086663004: [ieee754] Slightly improve unittests for exp/log.

Issue 2086663004: [ieee754] Slightly improve unittests for exp/log. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer

Modified:
4 years, 6 months ago

Reviewers:
Yang, Raymond Toy

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[ieee754] Slightly improve unittests for exp/log. BUG=v8:3266, v8:3468, v8:3493, v8:5086, v8:5108 R=rtoy@chromium.org Committed: https://crrev.com/f54fa4d426b2545d8bcc1373cd9650509115069b Cr-Commit-Position: refs/heads/master@{#37165}

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	test/unittests/base/ieee754-unittest.cc	View		3 chunks	+10 lines, -1 line	0 comments	Download

Total messages: 10 (3 generated)

Benedikt Meurer

Changed unittests slightly based on suggestions from Raymond in https://codereview.chromium.org/2079233005/. Please take a look.

4 years, 6 months ago (2016-06-22 03:57:49 UTC) #3

Yang

On 2016/06/22 03:57:49, Benedikt Meurer wrote: > Changed unittests slightly based on suggestions from Raymond ...

4 years, 6 months ago (2016-06-22 05:31:38 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086663004/1

4 years, 6 months ago (2016-06-22 05:31:46 UTC) #6

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/f54fa4d426b2545d8bcc1373cd9650509115069b Cr-Commit-Position: refs/heads/master@{#37165}

4 years, 6 months ago (2016-06-22 05:56:19 UTC) #9

Message was sent while issue was closed.

lgtm