Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: chrome/browser/ui/views/browser_dialogs_views.cc

Issue 2086663003: Change ChooserController ownership model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: changed some Cocoa function names to start with lowercase letter Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/browser_dialogs_views.cc
diff --git a/chrome/browser/ui/views/browser_dialogs_views.cc b/chrome/browser/ui/views/browser_dialogs_views.cc
index 952b90493470f7390f43114bc9e290e7e8e91736..8a0c833397add31a6143f656f826ebff6b1bfe9b 100644
--- a/chrome/browser/ui/views/browser_dialogs_views.cc
+++ b/chrome/browser/ui/views/browser_dialogs_views.cc
@@ -4,11 +4,14 @@
#include "chrome/browser/ui/browser_dialogs.h"
+#include <memory>
+
#include "chrome/browser/extensions/api/chrome_device_permissions_prompt.h"
#include "chrome/browser/extensions/chrome_extension_chooser_dialog.h"
#include "chrome/browser/extensions/extension_install_prompt.h"
#include "chrome/browser/ui/login/login_handler.h"
#include "chrome/browser/ui/views/new_task_manager_view.h"
+#include "components/chooser_controller/chooser_controller.h"
// This file provides definitions of desktop browser dialog-creation methods for
// all toolkit-views platforms other than Mac. It also provides the definitions
@@ -43,8 +46,8 @@ void ChromeDevicePermissionsPrompt::ShowDialog() {
}
void ChromeExtensionChooserDialog::ShowDialog(
- ChooserController* chooser_controller) const {
- ShowDialogImpl(chooser_controller);
+ std::unique_ptr<ChooserController> chooser_controller) const {
+ ShowDialogImpl(std::move(chooser_controller));
}
namespace chrome {

Powered by Google App Engine
This is Rietveld 408576698