Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6826)

Unified Diff: chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h

Issue 2086663003: Change ChooserController ownership model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address reillyg@'s comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h
diff --git a/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h b/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h
index c809112bcc07a48871042a2dd0f4e0ffdcde1496..932719f8422d8809648356b56e547a6ca9533280 100644
--- a/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h
+++ b/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h
@@ -5,6 +5,8 @@
#ifndef CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_CHOOSER_BUBBLE_UI_VIEW_H_
#define CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_CHOOSER_BUBBLE_UI_VIEW_H_
+#include <memory>
+
#include "base/macros.h"
#include "components/bubble/bubble_ui.h"
#include "ui/views/bubble/bubble_border.h"
@@ -24,7 +26,8 @@ class ChooserBubbleUiViewDelegate;
// BubbleManager.
class ChooserBubbleUiView : public BubbleUi {
public:
- ChooserBubbleUiView(Browser* browser, ChooserController* chooser_controller);
+ ChooserBubbleUiView(Browser* browser,
+ std::unique_ptr<ChooserController> chooser_controller);
~ChooserBubbleUiView() override;
// BubbleUi:
@@ -38,8 +41,6 @@ class ChooserBubbleUiView : public BubbleUi {
views::BubbleBorder::Arrow GetAnchorArrow();
Browser* browser_; // Weak.
- // Weak, owned by ChooserBubbleDelegate.
- ChooserController* chooser_controller_;
// Weak. Owned by its parent view.
ChooserBubbleUiViewDelegate* chooser_bubble_ui_view_delegate_;

Powered by Google App Engine
This is Rietveld 408576698