chrome/browser/ui/bluetooth/chrome_extension_bluetooth_chooser.h - Issue 2086663003: Change ChooserController ownership model

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bluetooth/chrome_extension_bluetooth_chooser.h

Issue 2086663003: Change ChooserController ownership model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address reillyg@'s comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/bluetooth/chrome_extension_bluetooth_chooser.h

diff --git a/chrome/browser/ui/bluetooth/chrome_extension_bluetooth_chooser.h b/chrome/browser/ui/bluetooth/chrome_extension_bluetooth_chooser.h

index 27ddcb4f0ee4f3a0d2dfe92a9048480e3488477c..bd021e85d8d02f8852fc5af18a9b65adf626f65f 100644

--- a/chrome/browser/ui/bluetooth/chrome_extension_bluetooth_chooser.h

+++ b/chrome/browser/ui/bluetooth/chrome_extension_bluetooth_chooser.h

@@ -34,7 +34,8 @@ class ChromeExtensionBluetoothChooser : public content::BluetoothChooser {

void RemoveDevice(const std::string& device_id) override;

private:

- std::unique_ptr<BluetoothChooserController> bluetooth_chooser_controller_;

+ // Weak. ChooserContentView(non-Mac)/ChooserContentViewCocoa(Mac) owns it.

+ BluetoothChooserController* bluetooth_chooser_controller_;

std::unique_ptr<ChromeExtensionChooserDialog> chooser_dialog_;

DISALLOW_COPY_AND_ASSIGN(ChromeExtensionBluetoothChooser);