Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Unified Diff: chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h

Issue 2086663003: Change ChooserController ownership model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix build errors Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h
diff --git a/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h b/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h
index 14fec0df35f6cb0d37770d73961a5fc798169afa..ccc72239ab33c2eaeadd7b42a40110afec0adb01 100644
--- a/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h
+++ b/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h
@@ -7,6 +7,8 @@
#import <Cocoa/Cocoa.h>
+#include <memory>
+
#include "base/mac/scoped_nsobject.h"
@class ChooserContentViewCocoa;
@@ -21,29 +23,16 @@ class ChooserDialogCocoa;
NSTableView* tableView_; // Weak.
NSButton* connectButton_; // Weak.
NSButton* cancelButton_; // Weak.
- NSButton* helpButton_; // Weak.
ChooserDialogCocoa* chooserDialogCocoa_; // Weak.
- ChooserController* chooserController_; // Weak.
}
// Designated initializer. |chooserDialogCocoa| and |chooserController|
// must both be non-nil.
- (instancetype)
initWithChooserDialogCocoa:(ChooserDialogCocoa*)chooserDialogCocoa
- chooserController:(ChooserController*)chooserController;
-
-// Update |tableView_| when chooser options were initialized.
-- (void)onOptionsInitialized;
-
-// Update |tableView_| when chooser option was added.
-- (void)onOptionAdded:(NSInteger)index;
-
-// Update |tableView_| when chooser option was removed.
-- (void)onOptionRemoved:(NSInteger)index;
-
-// Update |tableView_| when chooser options changed.
-- (void)updateTableView;
+ chooserController:
+ (std::unique_ptr<ChooserController>)chooserController;
// Called when the "Connect" button is pressed.
- (void)onConnect:(id)sender;
@@ -51,9 +40,6 @@ initWithChooserDialogCocoa:(ChooserDialogCocoa*)chooserDialogCocoa
// Called when the "Cancel" button is pressed.
- (void)onCancel:(id)sender;
-// Called when the "Get help" button is pressed.
-- (void)onHelpPressed:(id)sender;
-
// Gets the |chooserContentView_|. For testing only.
- (ChooserContentViewCocoa*)chooserContentView;

Powered by Google App Engine
This is Rietveld 408576698