chrome/browser/extensions/chrome_extension_chooser_dialog.h - Issue 2086663003: Change ChooserController ownership model

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_extension_chooser_dialog.h

Issue 2086663003: Change ChooserController ownership model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix build errors Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/chrome_extension_chooser_dialog.h

diff --git a/chrome/browser/extensions/chrome_extension_chooser_dialog.h b/chrome/browser/extensions/chrome_extension_chooser_dialog.h

index 0d597e90e7320ae91ad80cc8055b936c0d7466eb..bf02898c29e14ddf7e8a1c21093c5eeb2d195462 100644

--- a/chrome/browser/extensions/chrome_extension_chooser_dialog.h

+++ b/chrome/browser/extensions/chrome_extension_chooser_dialog.h

@@ -19,10 +19,11 @@ class ChromeExtensionChooserDialog {

: web_contents_(web_contents) {}

~ChromeExtensionChooserDialog() {}

- void ShowDialog(ChooserController* chooser_controller) const;

+ void ShowDialog(std::unique_ptr<ChooserController> chooser_controller) const;

private:

- void ShowDialogImpl(ChooserController* chooser_controller) const;

+ void ShowDialogImpl(

+ std::unique_ptr<ChooserController> chooser_controller) const;

content::WebContents* web_contents_;