Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Side by Side Diff: chrome/browser/ui/website_settings/chooser_bubble_delegate.h

Issue 2086663003: Change ChooserController ownership model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix build errors Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_DELEGATE_H_
6 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_DELEGATE_H_ 6 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_DELEGATE_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "components/bubble/bubble_delegate.h" 9 #include "components/bubble/bubble_delegate.h"
10 10
(...skipping 12 matching lines...) Expand all
23 explicit ChooserBubbleDelegate( 23 explicit ChooserBubbleDelegate(
24 content::RenderFrameHost* owner, 24 content::RenderFrameHost* owner,
25 std::unique_ptr<ChooserController> chooser_controller); 25 std::unique_ptr<ChooserController> chooser_controller);
26 ~ChooserBubbleDelegate() override; 26 ~ChooserBubbleDelegate() override;
27 27
28 // BubbleDelegate: 28 // BubbleDelegate:
29 std::string GetName() const override; 29 std::string GetName() const override;
30 std::unique_ptr<BubbleUi> BuildBubbleUi() override; 30 std::unique_ptr<BubbleUi> BuildBubbleUi() override;
31 const content::RenderFrameHost* OwningFrame() const override; 31 const content::RenderFrameHost* OwningFrame() const override;
32 32
33 ChooserController* chooser_controller() const {
34 return chooser_controller_.get();
35 }
36
37 private: 33 private:
38 const content::RenderFrameHost* const owning_frame_; 34 const content::RenderFrameHost* const owning_frame_;
39 Browser* browser_; 35 Browser* browser_;
36 // |chooser_controller_| is not owned by this class.
37 // It is owned by ChooserContentView. It is given to
38 // ChooserContentView at BuildBubbleUi() function.
40 std::unique_ptr<ChooserController> chooser_controller_; 39 std::unique_ptr<ChooserController> chooser_controller_;
41 40
42 DISALLOW_COPY_AND_ASSIGN(ChooserBubbleDelegate); 41 DISALLOW_COPY_AND_ASSIGN(ChooserBubbleDelegate);
43 }; 42 };
44 43
45 #endif // CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_DELEGATE_H_ 44 #endif // CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698