Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Side by Side Diff: chrome/browser/ui/website_settings/chooser_bubble_delegate.h

Issue 2086663003: Change ChooserController ownership model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed temporary unique ptr at ChooserBubbleUiCocoa Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_DELEGATE_H_
6 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_DELEGATE_H_ 6 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_DELEGATE_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "components/bubble/bubble_delegate.h" 9 #include "components/bubble/bubble_delegate.h"
10 10
11 class Browser; 11 class Browser;
12 class ChooserController; 12 class ChooserController;
13 13
14 namespace content { 14 namespace content {
15 class RenderFrameHost; 15 class RenderFrameHost;
16 } 16 }
17 17
18 // ChooserBubbleDelegate overrides GetName() to identify the bubble 18 // ChooserBubbleDelegate overrides GetName() to identify the bubble
19 // you define for collecting metrics. Create an instance of this 19 // you define for collecting metrics. Create an instance of this
20 // class and pass it to BubbleManager::ShowBubble() to show the bubble. 20 // class and pass it to BubbleManager::ShowBubble() to show the bubble.
21 class ChooserBubbleDelegate : public BubbleDelegate { 21 class ChooserBubbleDelegate : public BubbleDelegate {
22 public: 22 public:
23 explicit ChooserBubbleDelegate( 23 ChooserBubbleDelegate(content::RenderFrameHost* owner,
24 content::RenderFrameHost* owner, 24 std::unique_ptr<ChooserController> chooser_controller);
25 std::unique_ptr<ChooserController> chooser_controller);
26 ~ChooserBubbleDelegate() override; 25 ~ChooserBubbleDelegate() override;
27 26
28 // BubbleDelegate: 27 // BubbleDelegate:
29 std::string GetName() const override; 28 std::string GetName() const override;
30 std::unique_ptr<BubbleUi> BuildBubbleUi() override; 29 std::unique_ptr<BubbleUi> BuildBubbleUi() override;
31 const content::RenderFrameHost* OwningFrame() const override; 30 const content::RenderFrameHost* OwningFrame() const override;
32 31
33 ChooserController* chooser_controller() const {
34 return chooser_controller_.get();
35 }
36
37 private: 32 private:
38 const content::RenderFrameHost* const owning_frame_; 33 const content::RenderFrameHost* const owning_frame_;
39 Browser* browser_; 34 Browser* browser_;
35 // |chooser_controller_| is not owned by this class, it is owned by
36 // ChooserContentView[Cocoa].
37 // This field only temporarily owns the ChooserController. It is moved
38 // into the ChooserContentView[Cocoa] when BuildBubbleUi() is called
39 // and the bubble is shown.
40 std::unique_ptr<ChooserController> chooser_controller_; 40 std::unique_ptr<ChooserController> chooser_controller_;
41 41
42 DISALLOW_COPY_AND_ASSIGN(ChooserBubbleDelegate); 42 DISALLOW_COPY_AND_ASSIGN(ChooserBubbleDelegate);
43 }; 43 };
44 44
45 #endif // CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_DELEGATE_H_ 45 #endif // CHROME_BROWSER_UI_WEBSITE_SETTINGS_CHOOSER_BUBBLE_DELEGATE_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc ('k') | components/chooser_controller.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698