Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.mm

Issue 2086663003: Change ChooserController ownership model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed temporary unique ptr at ChooserBubbleUiCocoa Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.h" 5 #import "chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/single_thread_task_runner.h" 9 #include "base/single_thread_task_runner.h"
10 #include "base/threading/thread_task_runner_handle.h" 10 #include "base/threading/thread_task_runner_handle.h"
11 #include "chrome/browser/extensions/chrome_extension_chooser_dialog.h" 11 #include "chrome/browser/extensions/chrome_extension_chooser_dialog.h"
12 #include "chrome/browser/ui/browser_dialogs.h" 12 #include "chrome/browser/ui/browser_dialogs.h"
13 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sh eet.h" 13 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sh eet.h"
14 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_wi ndow.h" 14 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_wi ndow.h"
15 #import "chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h" 15 #import "chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h"
16 #include "components/chooser_controller/chooser_controller.h"
16 #include "components/web_modal/web_contents_modal_dialog_manager.h" 17 #include "components/web_modal/web_contents_modal_dialog_manager.h"
17 18
18 ChooserDialogCocoa::ChooserDialogCocoa(content::WebContents* web_contents, 19 ChooserDialogCocoa::ChooserDialogCocoa(
19 ChooserController* chooser_controller) 20 content::WebContents* web_contents,
20 : web_contents_(web_contents), chooser_controller_(chooser_controller) { 21 std::unique_ptr<ChooserController> chooser_controller)
22 : web_contents_(web_contents) {
21 DCHECK(web_contents_); 23 DCHECK(web_contents_);
22 DCHECK(chooser_controller_); 24 DCHECK(chooser_controller);
23 chooser_controller_->set_observer(this);
24 chooser_dialog_cocoa_controller_.reset([[ChooserDialogCocoaController alloc] 25 chooser_dialog_cocoa_controller_.reset([[ChooserDialogCocoaController alloc]
25 initWithChooserDialogCocoa:this 26 initWithChooserDialogCocoa:this
26 chooserController:chooser_controller_]); 27 chooserController:std::move(chooser_controller)]);
27 } 28 }
28 29
29 ChooserDialogCocoa::~ChooserDialogCocoa() {} 30 ChooserDialogCocoa::~ChooserDialogCocoa() {}
30 31
31 void ChooserDialogCocoa::OnConstrainedWindowClosed( 32 void ChooserDialogCocoa::OnConstrainedWindowClosed(
32 ConstrainedWindowMac* window) { 33 ConstrainedWindowMac* window) {
33 base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this); 34 base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);
34 } 35 }
35 36
36 void ChooserDialogCocoa::OnOptionsInitialized() {
37 if (chooser_dialog_cocoa_controller_)
38 [chooser_dialog_cocoa_controller_ onOptionsInitialized];
39 }
40
41 void ChooserDialogCocoa::OnOptionAdded(size_t index) {
42 if (chooser_dialog_cocoa_controller_)
43 [chooser_dialog_cocoa_controller_ onOptionAdded:index];
44 }
45
46 void ChooserDialogCocoa::OnOptionRemoved(size_t index) {
47 if (chooser_dialog_cocoa_controller_)
48 [chooser_dialog_cocoa_controller_ onOptionRemoved:index];
49 }
50
51 void ChooserDialogCocoa::ShowDialog() { 37 void ChooserDialogCocoa::ShowDialog() {
52 base::scoped_nsobject<NSWindow> window([[ConstrainedWindowCustomWindow alloc] 38 base::scoped_nsobject<NSWindow> window([[ConstrainedWindowCustomWindow alloc]
53 initWithContentRect:[[chooser_dialog_cocoa_controller_ view] bounds]]); 39 initWithContentRect:[[chooser_dialog_cocoa_controller_ view] bounds]]);
54 [[window contentView] addSubview:[chooser_dialog_cocoa_controller_ view]]; 40 [[window contentView] addSubview:[chooser_dialog_cocoa_controller_ view]];
55 base::scoped_nsobject<CustomConstrainedWindowSheet> sheet( 41 base::scoped_nsobject<CustomConstrainedWindowSheet> sheet(
56 [[CustomConstrainedWindowSheet alloc] initWithCustomWindow:window]); 42 [[CustomConstrainedWindowSheet alloc] initWithCustomWindow:window]);
57 constrained_window_ = 43 constrained_window_ =
58 CreateAndShowWebModalDialogMac(this, web_contents_, sheet); 44 CreateAndShowWebModalDialogMac(this, web_contents_, sheet);
59 } 45 }
60 46
61 void ChooserDialogCocoa::Dismissed() { 47 void ChooserDialogCocoa::Dismissed() {
62 if (constrained_window_) 48 if (constrained_window_)
63 constrained_window_->CloseWebContentsModalDialog(); 49 constrained_window_->CloseWebContentsModalDialog();
64 } 50 }
65 51
66 void ChromeExtensionChooserDialog::ShowDialog( 52 void ChromeExtensionChooserDialog::ShowDialog(
67 ChooserController* chooser_controller) const { 53 std::unique_ptr<ChooserController> chooser_controller) const {
68 if (chrome::ToolkitViewsWebUIDialogsEnabled()) 54 if (chrome::ToolkitViewsWebUIDialogsEnabled())
69 return ChromeExtensionChooserDialog::ShowDialogImpl(chooser_controller); 55 return ChromeExtensionChooserDialog::ShowDialogImpl(
56 std::move(chooser_controller));
70 57
71 web_modal::WebContentsModalDialogManager* manager = 58 web_modal::WebContentsModalDialogManager* manager =
72 web_modal::WebContentsModalDialogManager::FromWebContents(web_contents_); 59 web_modal::WebContentsModalDialogManager::FromWebContents(web_contents_);
73 if (manager) { 60 if (manager) {
74 // These objects will delete themselves when the dialog closes. 61 // These objects will delete themselves when the dialog closes.
75 ChooserDialogCocoa* chooser_dialog = 62 ChooserDialogCocoa* chooser_dialog =
76 new ChooserDialogCocoa(web_contents_, chooser_controller); 63 new ChooserDialogCocoa(web_contents_, std::move(chooser_controller));
77 chooser_dialog->ShowDialog(); 64 chooser_dialog->ShowDialog();
78 } 65 }
79 } 66 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698