Clean up WeakIdentifierMap<> implementation.

Clean up WeakIdentifierMap<> implementation.

Avoid (literal) code duplication between (non)GC versions
of WeakIdentifierMap<>.

Other changes (for the GC version):

  - Do not separately allocate the HeapHashMap<>s, but keep these
    as part objects on WeakIdentifierMap<> instead.
  - Support explicit removal (via notifyObjectDestroyed()).

R=
BUG=

Committed: https://crrev.com/0ca25bf2ec49526c331b85a7e29d4c4f5aa2db75
Cr-Commit-Position: refs/heads/master@{#400907}

[sof, 2016-06-20 20:45:09]

Description was changed from

==========
Clean up WeakIdentifierMap<> implementation.

Unnecessary amounts of code duplication preferrably avoided.

R=
BUG=
==========

to

==========
Clean up WeakIdentifierMap<> implementation.

Avoid (literal) code duplication between (non)GC versions
of WeakIdentifierMap<>.

Also avoid creating extra heap allocations for the HeapHashMaps and
keep these as part objects on WeakIdentifierMap<> instead.

R=
BUG=
==========

[sof, 2016-06-20 21:25:15]

Description was changed from

==========
Clean up WeakIdentifierMap<> implementation.

Avoid (literal) code duplication between (non)GC versions
of WeakIdentifierMap<>.

Also avoid creating extra heap allocations for the HeapHashMaps and
keep these as part objects on WeakIdentifierMap<> instead.

R=
BUG=
==========

to

==========
Clean up WeakIdentifierMap<> implementation.

Avoid (literal) code duplication between (non)GC versions
of WeakIdentifierMap<>.

Other changes (for the GC version):

  - Do not separately allocate the HeapHashMap<>s, but keep these
    as part objects on WeakIdentifierMap<> instead.
  - Support explicit removal (via notifyObjectDestroyed()).

R=
BUG=
==========

[sof, 2016-06-20 21:30:17]

sigbjornf@opera.com changed reviewers:
+ haraken@chromium.org, tkent@chromium.org

[sof, 2016-06-20 21:30:18]

please take a look.

[haraken, 2016-06-20 23:37:14]

LGTM, nice clean-up!

[sof, 2016-06-21 05:17:41]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-06-21 05:17:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2086643002/1

[commit-bot: I haz the power, 2016-06-21 06:19:09]

Description was changed from

==========
Clean up WeakIdentifierMap<> implementation.

Avoid (literal) code duplication between (non)GC versions
of WeakIdentifierMap<>.

Other changes (for the GC version):

  - Do not separately allocate the HeapHashMap<>s, but keep these
    as part objects on WeakIdentifierMap<> instead.
  - Support explicit removal (via notifyObjectDestroyed()).

R=
BUG=
==========

to

==========
Clean up WeakIdentifierMap<> implementation.

Avoid (literal) code duplication between (non)GC versions
of WeakIdentifierMap<>.

Other changes (for the GC version):

  - Do not separately allocate the HeapHashMap<>s, but keep these
    as part objects on WeakIdentifierMap<> instead.
  - Support explicit removal (via notifyObjectDestroyed()).

R=
BUG=
==========

[commit-bot: I haz the power, 2016-06-21 06:19:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-21 06:21:24]

Description was changed from

==========
Clean up WeakIdentifierMap<> implementation.

Avoid (literal) code duplication between (non)GC versions
of WeakIdentifierMap<>.

Other changes (for the GC version):

  - Do not separately allocate the HeapHashMap<>s, but keep these
    as part objects on WeakIdentifierMap<> instead.
  - Support explicit removal (via notifyObjectDestroyed()).

R=
BUG=
==========

to

==========
Clean up WeakIdentifierMap<> implementation.

Avoid (literal) code duplication between (non)GC versions
of WeakIdentifierMap<>.

Other changes (for the GC version):

  - Do not separately allocate the HeapHashMap<>s, but keep these
    as part objects on WeakIdentifierMap<> instead.
  - Support explicit removal (via notifyObjectDestroyed()).

R=
BUG=

Committed: https://crrev.com/0ca25bf2ec49526c331b85a7e29d4c4f5aa2db75
Cr-Commit-Position: refs/heads/master@{#400907}
==========

[commit-bot: I haz the power, 2016-06-21 06:21:25]

Patchset 1 (id:??) landed as
https://crrev.com/0ca25bf2ec49526c331b85a7e29d4c4f5aa2db75
Cr-Commit-Position: refs/heads/master@{#400907}