video_capture_manager: filter out unexpected app state changes on Android

There are much more APPLICATION_STATE_HAS_RUNNING_ACTIVITIES
updates than we expected (by mapping to both  activity.onstart
and activity.onresume). And we only care the state changes
from RUNNING->STOPPED->RUNNING (activity.onStart following
activty.stop) to release/resume camera devices accordingly.
So it's better to do the filtering earlier in
app_status_listener_ callback than making a
decision later by checking capturing status.

BUG=615557
TEST=AutoTest

Committed: https://crrev.com/3a8419c19e31739040e0eb30d2aef80cca469584
Cr-Commit-Position: refs/heads/master@{#402564}

[braveyao, 2016-06-20 18:22:31]

Description was changed from

==========
video_capture_manager: filter out unexpected app state changes on Android


BUG=615557
TEST=AutoTest
==========

to

==========
There are much more APPLICATION_STATE_HAS_RUNNING_ACTIVITIES
updates than we expected (by mapping to both  activity.onstart
and activity.onresume). And we only care the state changes
from RUNNING->STOPPED->RUNNING (activity.onStart following
activty.stop) to release/resume camera devices accordingly.
So it's better to do the filtering earlier in 
app_status_listener_ callback than making a
decision later by checking capturing status. 


BUG=615557
TEST=AutoTest
==========

[braveyao, 2016-06-27 22:32:50]

braveyao@chromium.org changed reviewers:
+ perkj@chromium.org

[braveyao, 2016-06-27 22:32:51]

Hi Per, this is the cl per what we discussed. Please take a look.

[perkj_chrome, 2016-06-28 08:59:26]

https://codereview.chromium.org/2086603002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/media/video_capture_manager.cc (right):

https://codereview.chromium.org/2086603002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/media/video_capture_manager.cc:1088:
has_stopped_activities) {
Suggest rename |has_stopped_activities| to
|application_state_has_running_activities_|  and change the check accordingly.

https://codereview.chromium.org/2086603002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/media/video_capture_manager.h (right):

https://codereview.chromium.org/2086603002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/media/video_capture_manager.h:289: bool
has_stopped_activities;
s/ has_stopped_activities_;

[perkj_chrome, 2016-06-28 09:00:56]

lgtm with the comments addressed.

[braveyao, 2016-06-28 21:42:44]

The CQ bit was checked by braveyao@chromium.org

[braveyao, 2016-06-28 21:42:44]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@chromium.org
Link to the patchset: https://codereview.chromium.org/2086603002/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2016-06-28 21:43:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 22:10:38]

Description was changed from

==========
There are much more APPLICATION_STATE_HAS_RUNNING_ACTIVITIES
updates than we expected (by mapping to both  activity.onstart
and activity.onresume). And we only care the state changes
from RUNNING->STOPPED->RUNNING (activity.onStart following
activty.stop) to release/resume camera devices accordingly.
So it's better to do the filtering earlier in 
app_status_listener_ callback than making a
decision later by checking capturing status. 


BUG=615557
TEST=AutoTest
==========

to

==========
There are much more APPLICATION_STATE_HAS_RUNNING_ACTIVITIES
updates than we expected (by mapping to both  activity.onstart
and activity.onresume). And we only care the state changes
from RUNNING->STOPPED->RUNNING (activity.onStart following
activty.stop) to release/resume camera devices accordingly.
So it's better to do the filtering earlier in 
app_status_listener_ callback than making a
decision later by checking capturing status. 


BUG=615557
TEST=AutoTest
==========

[commit-bot: I haz the power, 2016-06-28 22:10:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-28 22:12:36]

Description was changed from

==========
There are much more APPLICATION_STATE_HAS_RUNNING_ACTIVITIES
updates than we expected (by mapping to both  activity.onstart
and activity.onresume). And we only care the state changes
from RUNNING->STOPPED->RUNNING (activity.onStart following
activty.stop) to release/resume camera devices accordingly.
So it's better to do the filtering earlier in 
app_status_listener_ callback than making a
decision later by checking capturing status. 


BUG=615557
TEST=AutoTest
==========

to

==========
There are much more APPLICATION_STATE_HAS_RUNNING_ACTIVITIES
updates than we expected (by mapping to both  activity.onstart
and activity.onresume). And we only care the state changes
from RUNNING->STOPPED->RUNNING (activity.onStart following
activty.stop) to release/resume camera devices accordingly.
So it's better to do the filtering earlier in
app_status_listener_ callback than making a
decision later by checking capturing status.

BUG=615557
TEST=AutoTest

Committed: https://crrev.com/3a8419c19e31739040e0eb30d2aef80cca469584
Cr-Commit-Position: refs/heads/master@{#402564}
==========

[commit-bot: I haz the power, 2016-06-28 22:12:38]

Patchset 2 (id:??) landed as
https://crrev.com/3a8419c19e31739040e0eb30d2aef80cca469584
Cr-Commit-Position: refs/heads/master@{#402564}