Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2086533002: Fix a bug in QUIC's SpdyUtils where Content-Length was being parsed as an int, not an int64, causin… (Closed)

Created:
4 years, 6 months ago by ianswett
Modified:
4 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug in QUIC's SpdyUtils where Content-Length was being parsed as an int, not an int64, causing >4GB downloads to fail. Not flag protected. Merge internal change: 125208956 Fixes crbug/621295 R=rch@chromium.org BUG=621295 Committed: https://crrev.com/a387ce79f9344d421c2f03caf39869bd7f4f7b2a Cr-Commit-Position: refs/heads/master@{#400713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -4 lines) Patch
M net/quic/spdy_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/spdy_utils_test.cc View 1 chunk +31 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ianswett
4 years, 6 months ago (2016-06-20 16:14:04 UTC) #1
Ryan Hamilton
lgtm
4 years, 6 months ago (2016-06-20 16:32:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086533002/1
4 years, 6 months ago (2016-06-20 16:32:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 17:35:35 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 17:46:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a387ce79f9344d421c2f03caf39869bd7f4f7b2a
Cr-Commit-Position: refs/heads/master@{#400713}

Powered by Google App Engine
This is Rietveld 408576698