Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 208653010: Use service process to collect printers. (Closed)

Created:
6 years, 9 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Use service process to collect printers. Connector could have list of print servers in "Service State" file, so it could operate on different printers list. CUPS connector uses different printer name format than printing PrintBackendCUPS. BUG=350235 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259930

Patch Set 1 : #

Patch Set 2 : git cl format #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -59 lines) Patch
M chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc View 1 2 2 chunks +27 lines, -21 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.h View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc View 1 7 chunks +29 lines, -17 lines 0 comments Download
M chrome/browser/service_process/service_process_control.h View 5 chunks +19 lines, -3 lines 0 comments Download
M chrome/browser/service_process/service_process_control.cc View 1 3 chunks +27 lines, -1 line 0 comments Download
M chrome/common/service_messages.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy.cc View 1 4 chunks +26 lines, -10 lines 0 comments Download
M chrome/service/service_ipc_server.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/service/service_ipc_server.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 9 months ago (2014-03-24 22:47:47 UTC) #1
Vitaly Buka (NO REVIEWS)
6 years, 9 months ago (2014-03-24 23:08:43 UTC) #2
Noam Samuel
lgtm
6 years, 9 months ago (2014-03-24 23:31:19 UTC) #3
Vitaly Buka (NO REVIEWS)
+yoz for c/b/extensions/
6 years, 9 months ago (2014-03-25 00:12:33 UTC) #4
Vitaly Buka (NO REVIEWS)
+jschuh for chrome\common\service_messages.h
6 years, 9 months ago (2014-03-25 00:14:19 UTC) #5
Yoyo Zhou
rubber stamp c/b/e LGTM
6 years, 9 months ago (2014-03-25 00:22:33 UTC) #6
jschuh
ipc security lgtm. (notes: privileged <-> privileged)
6 years, 9 months ago (2014-03-25 14:40:57 UTC) #7
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-26 00:19:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/208653010/60001
6 years, 9 months ago (2014-03-26 00:21:38 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 01:41:54 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=287973
6 years, 9 months ago (2014-03-26 01:41:55 UTC) #11
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 9 months ago (2014-03-26 16:53:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/208653010/60001
6 years, 9 months ago (2014-03-26 16:54:44 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 18:27:03 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 9 months ago (2014-03-26 18:27:04 UTC) #15
Noam Samuel
On 2014/03/26 18:27:04, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 9 months ago (2014-03-26 18:31:42 UTC) #16
Vitaly Buka (NO REVIEWS)
Thanks. Tests probably need update. On Wed, Mar 26, 2014 at 11:31 AM, <noamsml@chromium.org> wrote: ...
6 years, 9 months ago (2014-03-26 18:35:55 UTC) #17
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-26 20:04:04 UTC) #18
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-26 20:04:20 UTC) #19
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-26 20:04:29 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/208653010/280001
6 years, 9 months ago (2014-03-26 20:07:56 UTC) #21
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-26 21:28:32 UTC) #22
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-26 21:29:04 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 04:54:01 UTC) #24
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-27 04:54:01 UTC) #25
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-27 17:48:42 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/208653010/280001
6 years, 9 months ago (2014-03-27 17:49:37 UTC) #27
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 17:52:15 UTC) #28
Message was sent while issue was closed.
Change committed as 259930

Powered by Google App Engine
This is Rietveld 408576698