Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2086513002: Fix classifier related bug (Closed)

Created:
4 years, 6 months ago by nickie
Modified:
4 years, 6 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix classifier related bug R=adamk@chromium.org BUG=chromium:621111 LOG=N Committed: https://crrev.com/2cabc866eca6e2f52ff339bf0307f390e712bf1e Cr-Commit-Position: refs/heads/master@{#37150}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix patch (&^%$#@! similarity) #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M src/parsing/parser-base.h View 3 chunks +9 lines, -6 lines 1 comment Download
A test/mjsunit/harmony/regress/regress-crbug-621111.js View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
nickie
4 years, 6 months ago (2016-06-20 15:36:21 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086513002/1
4 years, 6 months ago (2016-06-20 15:52:58 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-20 16:20:15 UTC) #7
nickie
https://codereview.chromium.org/2086513002/diff/1/src/parsing/parser-base.h File src/parsing/parser-base.h (right): https://codereview.chromium.org/2086513002/diff/1/src/parsing/parser-base.h#newcode3356 src/parsing/parser-base.h:3356: ExpressionClassifier classifier(this); This change was irrelevant to the bug. ...
4 years, 6 months ago (2016-06-21 07:33:15 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086513002/20001
4 years, 6 months ago (2016-06-21 08:10:10 UTC) #10
nickie
I uploaded a second PS because the similarity heuristic in git cl upload had decided ...
4 years, 6 months ago (2016-06-21 08:13:24 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-21 08:36:20 UTC) #13
adamk
lgtm
4 years, 6 months ago (2016-06-21 16:38:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086513002/20001
4 years, 6 months ago (2016-06-21 16:38:46 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 16:40:31 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 16:41:12 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2cabc866eca6e2f52ff339bf0307f390e712bf1e
Cr-Commit-Position: refs/heads/master@{#37150}

Powered by Google App Engine
This is Rietveld 408576698