Dump process type into breakpad.

android_webview/lib/main/aw_main_delegate.cc

Index: android_webview/lib/main/aw_main_delegate.cc
diff --git a/android_webview/lib/main/aw_main_delegate.cc b/android_webview/lib/main/aw_main_delegate.cc
index 7ead9624c33bb107db2ef0a16c20e56d9953fb1d..f133ba648874e7ee14e487c6eaba2e8dd8542e79 100644
--- a/android_webview/lib/main/aw_main_delegate.cc
+++ b/android_webview/lib/main/aw_main_delegate.cc
@@ -48,6 +48,10 @@ namespace android_webview {
 
 namespace {
 
+const char kWebViewSingleProcessType[] = "webview-singleprocess";

[Torne, 2016/06/25 14:05:16]

These seem really long; bikeshedding a bit, but it seems like webview-single,
webview-browser, webview-renderer is sufficient (the constants are named that
way after all) :)

[hush (inactive), 2016/06/27 22:15:26]

The problem with just "webview-browser" is only unambiguous when it appears
together with the other 2 process types. A crash/ dashboard reader who does not
read our code here will not know if this is for single process webview or
webview browser process in multiprocess mode.

Let's just be verbose and disperse any possible doubt..

+const char kWebViewBrowserProcessType[] = "webview-multiprocess-browser";
+const char kWebViewRendererProcessType[] = "webview-multiprocess-renderer";
+
 // TODO(boliu): Remove this global Allow once the underlying issues are
 // resolved - http://crbug.com/240453. See AwMainDelegate::RunProcess below.
 base::LazyInstance<std::unique_ptr<ScopedAllowWaitForLegacyWebViewApi>>
@@ -169,11 +173,14 @@ void AwMainDelegate::PreSandboxStartup() {
         base::File(pak_fd), pak_region, ui::SCALE_FACTOR_NONE);
     crash_signal_fd =
         global_descriptors->Get(kAndroidWebViewCrashSignalDescriptor);
+    process_type = kWebViewRendererProcessType;

[Torne, 2016/06/25 14:05:16]

Having a couple of hardcoded cases where we change the process type from one
string to another string seems weird - if we actually want all the webview
process types to be prefixed with "webview" then why not just actually do that
and prepend it to whatever the real process type is? I still think it'd be fine
to just use the real process type as-is, though.

[hush (inactive), 2016/06/27 22:15:26]

Just prepending "webview-" to process_type does not work very well because
process_type for the browser process (single process or browser process in
multiprocess mode) is an empty string.
Then we get:
webview-
webview-renderer.
This is not pretty. We need a way to tell the difference between single process
and multiprocess. 

   }
-  if (process_type.empty() &&
-      command_line.HasSwitch(switches::kSingleProcess)) {
-    // "webview" has a special treatment in breakpad_linux.cc.
-    process_type = "webview";
+  if (process_type.empty()) {
+    if (command_line.HasSwitch(switches::kSingleProcess)) {
+      process_type = kWebViewSingleProcessType;
+    } else {
+      process_type = kWebViewBrowserProcessType;
+    }
   }
 
   crash_reporter::EnableMicrodumpCrashReporter(process_type, crash_signal_fd);