Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2086483002: Fix the signature of PasswordFormManager::UpdateMetadataForUsage (Closed)

Created:
4 years, 6 months ago by vabr (Chromium)
Modified:
4 years, 6 months ago
Reviewers:
kolos1
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the signature of PasswordFormManager::UpdateMetadataForUsage The method took a const reference for a PasswordForm, but never used it. Instead it hard-coded using pending_credentials_, which was passed as the argument all the times anyway. This CL changes the function to use its argument, changes the argument from a const ref to a non-const pointer to allow modification, and moves the function to the anonymous namespace, because it does not need any state of PasswordFormManager. R=kolos@chromium.org BUG=621355 Committed: https://crrev.com/848ab72cddf925c8554b0fd7713fa2c919807e2f Cr-Commit-Position: refs/heads/master@{#400683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M components/password_manager/core/browser/password_form_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 4 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
vabr (Chromium)
Hi Maxim, Could you please review? Thanks! Vaclav
4 years, 6 months ago (2016-06-20 14:39:33 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086483002/1
4 years, 6 months ago (2016-06-20 14:51:31 UTC) #3
kolos1
Thanks, Vaclav. LGTM nit: could you add some test to PasswordFormManager to check that |times_used| ...
4 years, 6 months ago (2016-06-20 15:03:38 UTC) #4
vabr (Chromium)
On 2016/06/20 15:03:38, kolos1 wrote: > Thanks, Vaclav. LGTM > > nit: could you add ...
4 years, 6 months ago (2016-06-20 15:09:46 UTC) #5
kolos1
On 2016/06/20 15:09:46, vabr (Chromium) wrote: > On 2016/06/20 15:03:38, kolos1 wrote: > > Thanks, ...
4 years, 6 months ago (2016-06-20 15:11:35 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-20 15:24:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086483002/1
4 years, 6 months ago (2016-06-20 15:32:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 15:38:10 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 15:40:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/848ab72cddf925c8554b0fd7713fa2c919807e2f
Cr-Commit-Position: refs/heads/master@{#400683}

Powered by Google App Engine
This is Rietveld 408576698