Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2086453002: Log First User Interaction in Page Load Metrics (Closed)

Created:
4 years, 6 months ago by Charlie Harrison
Modified:
4 years, 6 months ago
Reviewers:
Bryan McQuade
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, loading-reviews+metrics_chromium.org, nyquist+watch-blimp_chromium.org, csharrison+watch_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, asvitkine+watch_chromium.org, lethalantidote+watch-blimp_chromium.org, darin-cc_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Log First User Interaction in Page Load Metrics Learn more at: https://docs.google.com/document/d/1-OEDCDZPjWQHpmuGzaNxz9cRH4bEQXCo4x04ydazYtQ/edit BUG=612422 NOPRESUBMIT=true NOTRY=true TBR=bmcquade@chromium.org,asvitkine@chromium.org,jam@chromium.org Review-Url: https://codereview.chromium.org/1984173002 Cr-Commit-Position: refs/heads/master@{#398128} (cherry picked from commit 48cac60dbb50219805cc59e04ad50022c0288bc7)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+389 lines, -33 lines) Patch
M blimp/engine/feature/engine_render_widget_feature_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h View 6 chunks +33 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc View 9 chunks +120 lines, -17 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc View 2 chunks +88 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M components/page_load_metrics/browser/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M components/page_load_metrics/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/page_load_metrics/browser/metrics_web_contents_observer.h View 7 chunks +23 lines, -7 lines 0 comments Download
M components/page_load_metrics/browser/metrics_web_contents_observer.cc View 5 chunks +43 lines, -1 line 0 comments Download
M components/page_load_metrics/browser/page_load_metrics_observer.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 3 chunks +12 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 8 chunks +26 lines, -6 lines 0 comments Download
M content/public/browser/render_widget_host.h View 1 chunk +12 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086453002/1
4 years, 6 months ago (2016-06-20 13:58:33 UTC) #3
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 6 months ago (2016-06-20 13:58:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086453002/1
4 years, 6 months ago (2016-06-20 14:00:04 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 14:04:23 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698