Support completely serialized compilation in batch mode.

Support completely serialized compilation in batch mode.

This adds the ability to serialize the whole program and compiling it
purely from serialized data. The features is added to batch-mode under
the environment flag SERIALIZED_COMPILATION.

R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/035781504f9b3813799bc52f1e319037d96cbc37

[Johnni Winther, 2016-06-20 13:37:02]

johnniwinther@google.com changed reviewers:
+ het@google.com

[Harry Terkelsen, 2016-06-20 16:36:11]

lgtm

https://codereview.chromium.org/2086443002/diff/1/pkg/compiler/lib/src/dart2j...
File pkg/compiler/lib/src/dart2js.dart (right):

https://codereview.chromium.org/2086443002/diff/1/pkg/compiler/lib/src/dart2j...
pkg/compiler/lib/src/dart2js.dart:839:
Platform.environment['USE_SERIALIZED_DART_CORE'] == 'true';
this and SERIALIZED_COMPILATION should use const bool.fromEnvironment

https://codereview.chromium.org/2086443002/diff/1/pkg/compiler/lib/src/dart2j...
pkg/compiler/lib/src/dart2js.dart:855: String serializedData) async {
this doesn't look like it needs to be async

https://codereview.chromium.org/2086443002/diff/1/pkg/compiler/lib/src/dart2j...
pkg/compiler/lib/src/dart2js.dart:879: [String serializedData]) async {
ditto

https://codereview.chromium.org/2086443002/diff/1/pkg/compiler/lib/src/dart2j...
pkg/compiler/lib/src/dart2js.dart:894: String serializedDartCoreData;
nit: consider renaming to serializedDartCore in the spirit of
http://journal.stuffwithstuff.com/2016/06/16/long-names-are-long/

https://codereview.chromium.org/2086443002/diff/1/pkg/compiler/lib/src/dart2j...
pkg/compiler/lib/src/dart2js.dart:898: Future<api.CompilationResult>
compileWithSerializedTestData(
I'm not sure what 'Test' means in this context

[Johnni Winther, 2016-06-23 09:23:14]

Description was changed from

==========
Support completely serialized compilation in batch mode.

This adds the ability to serialize the whole program and compiling it
purely from serialized data. The features is added to batch-mode under
the environment flag SERIALIZED_COMPILATION.
==========

to

==========
Support completely serialized compilation in batch mode.

This adds the ability to serialize the whole program and compiling it
purely from serialized data. The features is added to batch-mode under
the environment flag SERIALIZED_COMPILATION.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/035781504f9b3813799bc52f1e319037d96cbc37
==========

[Johnni Winther, 2016-06-23 09:23:15]

Committed patchset #2 (id:20001) manually as
035781504f9b3813799bc52f1e319037d96cbc37 (presubmit successful).

[Johnni Winther, 2016-06-23 13:07:48]

https://codereview.chromium.org/2086443002/diff/1/pkg/compiler/lib/src/dart2j...
File pkg/compiler/lib/src/dart2js.dart (right):

https://codereview.chromium.org/2086443002/diff/1/pkg/compiler/lib/src/dart2j...
pkg/compiler/lib/src/dart2js.dart:839:
Platform.environment['USE_SERIALIZED_DART_CORE'] == 'true';
On 2016/06/20 16:36:11, Harry Terkelsen wrote:
> this and SERIALIZED_COMPILATION should use const bool.fromEnvironment

Yes. I initially wanted to but (on Windows at least) environmental variables are
not accessible via `.fromEnvironment` constructors - and I need to set them for
a whole test-run.

Added a TODO to change them when we add an option to the test script.

https://codereview.chromium.org/2086443002/diff/1/pkg/compiler/lib/src/dart2j...
pkg/compiler/lib/src/dart2js.dart:855: String serializedData) async {
On 2016/06/20 16:36:11, Harry Terkelsen wrote:
> this doesn't look like it needs to be async

Done.

https://codereview.chromium.org/2086443002/diff/1/pkg/compiler/lib/src/dart2j...
pkg/compiler/lib/src/dart2js.dart:879: [String serializedData]) async {
On 2016/06/20 16:36:11, Harry Terkelsen wrote:
> ditto

Done.

https://codereview.chromium.org/2086443002/diff/1/pkg/compiler/lib/src/dart2j...
pkg/compiler/lib/src/dart2js.dart:894: String serializedDartCoreData;
On 2016/06/20 16:36:11, Harry Terkelsen wrote:
> nit: consider renaming to serializedDartCore in the spirit of
> http://journal.stuffwithstuff.com/2016/06/16/long-names-are-long/

Done.

https://codereview.chromium.org/2086443002/diff/1/pkg/compiler/lib/src/dart2j...
pkg/compiler/lib/src/dart2js.dart:898: Future<api.CompilationResult>
compileWithSerializedTestData(
On 2016/06/20 16:36:11, Harry Terkelsen wrote:
> I'm not sure what 'Test' means in this context

Renamed to 'compileFromSerializedData'