tools/perf/measurements/thread_times.py - Issue 208643007: Add cleanup for measurements that use tracing

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/measurements/thread_times.py

Issue 208643007: Add cleanup for measurements that use tracing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from metrics import timeline	5 from metrics import timeline

6 from telemetry.page import page_measurement	6 from telemetry.page import page_measurement

7	7

8 class ThreadTimes(page_measurement.PageMeasurement):	8 class ThreadTimes(page_measurement.PageMeasurement):

9 def __init__(self):	9 def __init__(self):

10 super(ThreadTimes, self).__init__('RunSmoothness')	10 super(ThreadTimes, self).__init__('RunSmoothness')

(...skipping 19 matching lines...) Expand all Loading...
30 self._metric.Start(page, tab)	30 self._metric.Start(page, tab)

31	31

32 def DidRunAction(self, page, tab, action):	32 def DidRunAction(self, page, tab, action):

33 self._metric.AddActionToIncludeInMetric(action)	33 self._metric.AddActionToIncludeInMetric(action)

34	34

35 def DidRunActions(self, page, tab):	35 def DidRunActions(self, page, tab):

36 self._metric.Stop(page, tab)	36 self._metric.Stop(page, tab)

37	37

38 def MeasurePage(self, page, tab, results):	38 def MeasurePage(self, page, tab, results):

39 self._metric.AddResults(tab, results)	39 self._metric.AddResults(tab, results)

	40

	41 def CleanUpAfterPage(self, _, tab):

	42 self._metric.CleanUp(tab)

OLD	NEW